PML-157: Fixing and readding percona-mongolink Version test #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithquinnpercona
requested review from
olexandr-havryliak and
sandraromanchenko
as code owners
sandraromanchenko
requested changes
May 23, 2025
pml/tests/test_plm.py
Outdated
Comment on lines
196
to
201
| assert parsed_config['Version'] == f"release-{version}", parsed_config | ||
| assert parsed_config['Platform'] == get_git_commit(), parsed_config | ||
| assert parsed_config['GitCommit'], parsed_config | ||
| assert parsed_config['GitBranch'], parsed_config | ||
| assert parsed_config['BuildTime'], parsed_config | ||
| assert parsed_config['GoVersion'], parsed_config |
There was a problem hiding this comment.
Your check doesn't match output, which should look like:
Version: v0.5.0
Platform: linux
GitCommit: 3c8b832
GitBranch: release-0.5.0
BuildTime: 2025-05-23_08:59_UTC
GoVersion: go1.24.2
sandraromanchenko
approved these changes
May 23, 2025
olexandr-havryliak
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
percona-mongolink version command has been fixed to now show the correct format and extra details. The test was commented out due until the fix.