Skip to content

Add PLModulePass to abstract away low-level details of xDSL's ModulePass #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: migrate-unified-compiler
Choose a base branch
from
Draft

Add PLModulePass to abstract away low-level details of xDSL's ModulePass #2211

wants to merge 6 commits into from
+319 −0

Conversation

@mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Nov 19, 2025

@mudit2812 mudit2812 mentioned this pull request Nov 19, 2025
Closed
@mudit2812 mudit2812 changed the title [PROTOTYPE] Add prototype implementation of PLModulePass [PROTOTYPE] Add prototype implementation of xDSL PLModulePass Nov 19, 2025
@mudit2812 mudit2812 added the unified compiler Pull requests for the integration with xDSL label Nov 19, 2025
mudit2812
mudit2812 commented Dec 2, 2025
View reviewed changes
frontend/catalyst/python_interface/pass_api/passes.py
Comment on lines +148 to +150
# xdsl.pattern_rewriter.op_type_rewrite_pattern was used as a reference to
# implement the type hint collection. Source:
# https://github.com/xdslproject/xdsl/blob/main/xdsl/pattern_rewriter.py
Copy link
Contributor Author

@mudit2812 mudit2812 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xDSL uses the Apache 2.0 license, so this should be fine, right? The functionality mentioned in this comment is not something that does anything actually related to xDSL or compilation either.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

mudit2812
mudit2812 commented Dec 2, 2025
View reviewed changes
frontend/catalyst/python_interface/pass_api/cancel_inverses_prototype.py
Copy link
Contributor Author

@mudit2812 mudit2812 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be removed before merging the PR.

@mudit2812 mudit2812 changed the title [PROTOTYPE] Add prototype implementation of xDSL PLModulePass Add PLModulePass to abstract away low-level details of xDSL's ModulePass Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

unified compiler Pull requests for the integration with xDSL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mudit2812