Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[NC-2005] CLI fixes. #630

Merged
merged 6 commits into from
Jan 23, 2019
Merged

[NC-2005] CLI fixes. #630

merged 6 commits into from
Jan 23, 2019

Conversation

mark-terry
Copy link
Contributor

PR description

Fixes to accommodate PicoCLI boolean behaviour.

Fixed Issue(s)

#NC-2005

macfarla
macfarla approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NicolasMassart
NicolasMassart approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you test that overriding from config is ok

@mark-terry mark-terry merged commit 4d0ddb9 into PegaSysEng:master Jan 23, 2019
@mark-terry mark-terry deleted the NC-2005-FIX branch January 23, 2019 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@macfarla macfarla macfarla approved these changes

@lucassaldanha lucassaldanha Awaiting requested review from lucassaldanha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mark-terry @macfarla @NicolasMassart