This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[EC-183] Added RLP enc/dec for PrePrepare, Commit and NewRound messages #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rain-on
reviewed
Nov 21, 2018
...java/tech/pegasys/pantheon/consensus/ibft/ibftmessagedata/IbftUnsignedCommitMessageData.java
Show resolved
Hide resolved
...va/tech/pegasys/pantheon/consensus/ibft/ibftmessagedata/IbftUnsignedNewRoundMessageData.java
Outdated
Show resolved
Hide resolved
jframe
reviewed
Nov 21, 2018
...s/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/ibftmessage/IbftCommitMessage.java
Outdated
Show resolved
Hide resolved
saltiniroberto
force-pushed
the
add_ibft2_preprepare_commit_new_round_rlp_enc_dec
branch
from
e13b0e8 to
6cea040
Compare
saltiniroberto
force-pushed
the
add_ibft2_preprepare_commit_new_round_rlp_enc_dec
branch
from
6cea040 to
7d97c4c
Compare
jframe
approved these changes
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds the RLP encoding/decoding for the iBFT 2.0 PrePrepare, Commit and NewRound messages.
Tests will be added as part of another PR.
Also, see #153 for comments to the same PR raised before making the repo public.