This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Discard known remote transactions prior to validation #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
On MainNet we receive a lot of incoming remote transactions (up to 1,000 messages/sec which may contain multiple transactions). Currently, we validate each transaction, then check if it's already in the transaction pool. Instead, we should check if the transaction already exists and immediately discard it if so.
It's still possible that we'll wind up validating the same transaction twice (at the same time) because it wasn't present, two threads started validation and ultimately only one will actually be able to add it. However, since we only have two threads handling incoming transaction messages, the number of times we validate the transaction will be at most twice.