This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
AT DSL - Removing WaitCondition, consistently applying Condition instead #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoving-waituntil-from-node
…emoving-waituntil-from-node
jframe
reviewed
Jun 3, 2019
|
|
||
| minerNode1.execute(cliqueTransactions.createAddProposal(minerNode2)); | ||
| cluster.waitUntil(wait.chainHeadHasProgressedByAtLeast(minerNode1, 1)); | ||
| cluster.verify(blockchain.minimumHeightProgression(minerNode1, 1)); |
There was a problem hiding this comment.
progression sounds a bit odd here. Is there a consistent phrasing or tense used or meant to be used for the dsl?
There was a problem hiding this comment.
suggested alternative?
There was a problem hiding this comment.
blockchain.reachesHeight() ?
rain-on
reviewed
Jun 3, 2019
| minerNode1.execute(cliqueTransactions.createAddProposal(minerNode3)); | ||
| minerNode2.execute(cliqueTransactions.createAddProposal(minerNode3)); | ||
| cluster.waitUntil(cliqueValidatorsChanged); | ||
| cluster.verify(cliqueValidatorsChanged); |
There was a problem hiding this comment.
This line should be removed - if we're ditching the "waiting" concept, then no need to ensure miner1 has changed - just ensure all the cluster have in the next line (and thus line 38 can probably go too).
jframe
approved these changes
Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
WaitCondition is really a Condition :. removing WaitCondition
Fixed Issue(s)