This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Added Genesis file support for specifying the maximum stack size. #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
May 10, 2019
| @Override | ||
| public OptionalInt getStackSizeLimit() { | ||
| return configRoot.containsKey("configstacksizelimit") | ||
| ? OptionalInt.of(configRoot.getInteger("configstacksizelimit")) |
There was a problem hiding this comment.
I'm surprised this is configstacksizelimit instead of just stacksizelimit or maybe even evmstacksizelimit.
There was a problem hiding this comment.
Now reads as:
getEvmStackSize() and
"evmstacksize"
| @@ -176,7 +176,7 @@ | |||
| MESSAGE_CALL, | |||
| } | |||
|
|
|||
| private static final int MAX_STACK_SIZE = 1024; | |||
| public static final int MAX_STACK_SIZE = 1024; | |||
There was a problem hiding this comment.
nit: Rename to DEFAULT_MAX_STACK_SIZE
rojotek
force-pushed
the
make-stack-size-configurable
branch
4 times, most recently
from
0d6fa1e to
4743dd6
Compare
rojotek
force-pushed
the
make-stack-size-configurable
branch
from
4743dd6 to
de87aa6
Compare
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Genesis file support for specifying the maximum stack size, useful for private networks.