Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2576] Allow whitespace in path #1327

Conversation

AbdelStark
Copy link
Contributor

PR description

  • handle whitespace in path
  • handle parentheses in path

Fixed Issue(s)

fixes #PAN-2576

- handle whitespace in path
- handle parentheses in path

fixes PAN-2576
@AbdelStark AbdelStark added the bug Something isn't working label Apr 24, 2019
@AbdelStark
Copy link
Contributor Author

Follow up ticket has been created to generalize the approach to other cases where file paths are loaded the same way.
#PIE-1531

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with a follow up on other places where we use Resources.getResource in Pantheon code.

@AbdelStark AbdelStark merged commit 6e77605 into PegaSysEng:master Apr 24, 2019
notlesh pushed a commit to notlesh/pantheon that referenced this pull request Apr 24, 2019
* [PAN-2576] Allow whitespace in path

- handle whitespace in path
- handle parentheses in path

fixes PAN-2576

* Update SECP256K1Test.java

* Update GenesisConfigFile.java

* Revert "Update GenesisConfigFile.java"

This reverts commit 08bedbf.
notlesh pushed a commit to notlesh/pantheon that referenced this pull request May 4, 2019
* [PAN-2576] Allow whitespace in path

- handle whitespace in path
- handle parentheses in path

fixes PAN-2576

* Update SECP256K1Test.java

* Update GenesisConfigFile.java

* Revert "Update GenesisConfigFile.java"

This reverts commit 08bedbf.
@AbdelStark AbdelStark deleted the feature/pan-2576-allow-space-key-file-path branch May 17, 2019 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants