This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix running ATs with in-process node runner #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatthewenglish
approved these changes
Apr 15, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
Supplies an EthereumWireProtocolConfiguration when creating PantheonController.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
Supplies an EthereumWireProtocolConfiguration when creating PantheonController.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix running ATs with the threaded pantheon node runner. It wasn't setting an
EthereumWireProtocolConfiguration. Supply a default config in thePantheonControllerBuilderto avoid requiring more boilerplate to start an embedded pantheon.