Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure the Avro synced types are the same #117

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

iskakaushik
Copy link
Contributor

Note for bigquery the precision we are allowing is milli second level, this might need to be reconsidered.

case *big.Rat:
return value, true
case string:
parsed, ok := new(big.Rat).SetString(value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
G113: Potential uncontrolled memory consumption in Rat.SetString (CVE-2022-23772) (gosec)

@iskakaushik iskakaushik merged commit dd33ecf into main Jun 10, 2023
@serprex serprex deleted the avro-type-test branch December 25, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant