-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish a consistent naming scheme of global objects #14
Comments
I agree that we need a global standard, but |
Do we need init, can't alert just be a function? Something like |
Also, do we need init at all? If Bootstrap can do without init, shouldn't we too? |
I registered #16 for making Design Guide do |
The problem is that some of the components have utility functions, and per the issue, the goal is to keep it consistent. We don't NEED the init functions, they are there to give users more control over the components should they wish to do so. |
Yeah, I agree with using the name as the initializer, the problem is when a component name contains utility functions as well. |
|
The general Design Guide scripts are located in the object
px.script
. I think the wordscript
here makes no sense. Why not call itPayEx.DesignGuide
? We obviously need to establish a global standard around JavaScript namespacing in PayEx, as Checkout v2 is usingpayex.hostedView
for instance.Creating all of these global, inconsistently named objects is confusing and looks unprofessional. I think it should be down to the Design Guide to establish how these global objects are named and in that case eCom might have made the choice for us in its rollout of
payex.hostedView
.I would prefer pascal casing for "classes" as this, but consistency is more important than my personal preference. I therefore suggest the Design Guide groups all of its globals into
payex.designGuide.*
.The text was updated successfully, but these errors were encountered: