maint(pat auto submit): Use JS submit event instead of jQuery.

Author: thet

src/pat/auto-submit/auto-submit.js

@@ -1,6 +1,7 @@
 import "../../core/jquery-ext";
 import $ from "jquery";
 import Base from "../../core/base";
+import events from "../../core/events";
 import input_change_events from "../../lib/input-change-events";
 import logging from "../../core/logging";
 import Parser from "../../core/parser";
@@ -43,7 +44,7 @@ export default Base.extend({
                 data?.pattern === "sortable"
             ) {
                 // Directly submit when removing a clone or changing the sorting.
-                this.$el.submit();
+                this.el.dispatchEvent(events.submit_event());
                 log.debug(
                     `triggered by pat-update, pattern: ${data.pattern}, action: ${data.action}`
                 );
@@ -119,7 +120,7 @@ export default Base.extend({
 
     onInputChange(e) {
         e.stopPropagation();
-        this.$el.submit();
+        this.el.dispatchEvent(events.submit_event());
         log.debug("triggered by " + e.type);
     },
 });

src/pat/auto-submit/auto-submit.test.js

@@ -69,7 +69,7 @@ describe("pat-autosubmit", function () {
     });
 
     describe("2 - Trigger a submit", function () {
-        it("when a change on a single input happens", async function () {
+        it("when a change on a single input happens", function () {
             document.body.innerHTML = `
               <form>
                 <input
@@ -82,10 +82,13 @@ describe("pat-autosubmit", function () {
             `;
             const input = document.querySelector(".pat-autosubmit");
             const instance = new Pattern(input);
-            const spy = jest.spyOn(instance.$el, "submit");
+            let called = false;
+            instance.el.addEventListener("submit", (e) => {
+                e.preventDefault();
+                called = true;
+            });
             input.dispatchEvent(events.input_event());
-            await utils.timeout(1);
-            expect(spy).toHaveBeenCalled();
+            expect(called).toBe(true);
         });
 
         it("when pat-clone removes an element", function () {
@@ -95,9 +98,13 @@ describe("pat-autosubmit", function () {
             `;
             const el = document.querySelector(".pat-autosubmit");
             const instance = new Pattern(el);
-            const spy = jest.spyOn(instance.$el, "submit");
+            let called = false;
+            instance.el.addEventListener("submit", (e) => {
+                e.preventDefault();
+                called = true;
+            });
             $(el).trigger("pat-update", { pattern: "clone", action: "remove" });
-            expect(spy).toHaveBeenCalled();
+            expect(called).toBe(true);
         });
 
         it("when pat-sortable changes the sorting", function () {
@@ -107,9 +114,13 @@ describe("pat-autosubmit", function () {
             `;
             const el = document.querySelector(".pat-autosubmit");
             const instance = new Pattern(el);
-            const spy = jest.spyOn(instance.$el, "submit");
+            let called = false;
+            instance.el.addEventListener("submit", (e) => {
+                e.preventDefault();
+                called = true;
+            });
             $(el).trigger("pat-update", { pattern: "sortable" });
-            expect(spy).toHaveBeenCalled();
+            expect(called).toBe(true);
         });
     });
 

src/pat/auto-suggest/auto-suggest.test.js

@@ -292,13 +292,17 @@ describe("pat-autosuggest", function () {
             const input = document.querySelector("input");
             new pattern(input);
             const instance_autosubmit = new pattern_autosubmit(input);
-            const spy = jest.spyOn(instance_autosubmit.$el, "submit");
+            let called = false;
+            instance_autosubmit.el.addEventListener("submit", (e) => {
+                e.preventDefault();
+                called = true;
+            });
             await utils.timeout(1); // wait a tick for async to settle.
 
             $(".select2-input").click();
             $(document.querySelector(".select2-result")).mouseup();
 
-            expect(spy).toHaveBeenCalled();
+            expect(called).toBe(true);
         });
     });
 });