tech(code dom): Rename toNodeArray to to_node_array, keeping the old name for BBB.

This is done to align the names according the naming conventions in
Patternslib. Also, this is not a breaking change, as toNodeArray is now
nowhere used (we're using to_element_array instead) and we kept the old
name as alias for backwards compatibility.

Author: thet

src/core/dom.js

@@ -41,7 +41,7 @@ const document_ready = (fn) => {
  *
  * @returns {Array} - An array of DOM nodes.
  */
-const toNodeArray = (nodes) => {
+const to_node_array = (nodes) => {
     if (nodes?.jquery || nodes instanceof NodeList) {
         nodes = [...nodes];
     } else if (nodes instanceof Array === false) {
@@ -60,7 +60,7 @@ const toNodeArray = (nodes) => {
  * @returns {Array} - An array of DOM elements.
  */
 const to_element_array = (nodes) => {
-    nodes = toNodeArray(nodes);
+    nodes = to_node_array(nodes);
     // Filter for DOM elements only.
     nodes = nodes.filter((node) => node instanceof Element);
     return nodes;
@@ -635,7 +635,8 @@ const find_inputs = (el) => {
 const dom = {
     document_ready: document_ready,
     to_element_array: to_element_array,
-    toNodeArray: toNodeArray,
+    to_node_array: to_node_array,
+    toNodeArray: to_node_array, // BBB.
     querySelectorAllAndMe: querySelectorAllAndMe,
     wrap: wrap,
     hide: hide,

src/core/dom.test.js

@@ -88,7 +88,7 @@ describe("core.dom tests", () => {
         });
     });
 
-    describe("toNodeArray tests", () => {
+    describe("to_node_array tests", () => {
         it("returns an array of nodes, if a jQuery object was passed.", (done) => {
             const html = document.createElement("div");
             html.innerHTML = `
@@ -100,7 +100,7 @@ describe("core.dom tests", () => {
             const testee = $("span", html);
             expect(testee.length).toBe(2);
 
-            const ret = dom.toNodeArray(testee);
+            const ret = dom.to_node_array(testee);
 
             expect(ret.jquery).toBeFalsy();
             expect(ret.length).toBe(2);
@@ -127,7 +127,7 @@ describe("core.dom tests", () => {
             const testee = html.querySelectorAll("span");
             expect(testee.length).toBe(2);
 
-            const ret = dom.toNodeArray(testee);
+            const ret = dom.to_node_array(testee);
             expect(ret instanceof NodeList).toBeFalsy();
             expect(ret.length).toBe(2);
             expect(ret[0]).toBe(el1);
@@ -139,7 +139,7 @@ describe("core.dom tests", () => {
         it("returns an array with a single node, if a single node was passed.", (done) => {
             const html = document.createElement("div");
 
-            const ret = dom.toNodeArray(html);
+            const ret = dom.to_node_array(html);
             expect(ret instanceof Array).toBeTruthy();
             expect(ret.length).toBe(1);
             expect(ret[0]).toBe(html);
@@ -148,7 +148,7 @@ describe("core.dom tests", () => {
         });
 
         it("returns an empty array, if nothing was passed", (done) => {
-            const ret = dom.toNodeArray();
+            const ret = dom.to_node_array();
             expect(ret.length).toBe(0);
             expect(ret instanceof Array).toBe(true);
 
@@ -165,6 +165,17 @@ describe("core.dom tests", () => {
 
             done();
         });
+
+        it("returns only DOM Nodes, using the deprecated name", (done) => {
+            const el = document.body;
+            const txt = document.createTextNode("okay");
+            const ret = dom.toNodeArray([1, false, txt, "okay", el]);
+            expect(ret.length).toBe(2);
+            expect(ret[0]).toBe(txt);
+            expect(ret[1]).toBe(el);
+
+            done();
+        });
     });
 
     describe("to_element_array tests", () => {