Skip to content

Conversation

@NL908
Copy link
Contributor

@NL908 NL908 commented Nov 8, 2025

Added Foulborn Might of the Meek modifiers (manully edit the value and jewel raidus for now)

Fixes #9219 .

Description of the problem being solved:

Might of the Meek and the Light of Meaning interaction does not work.

There's a type check when calculating Increased Effect that needs the value to be "number".

NOTE: There might be a potential bug between Tattoo, Warrior's Tale (Ancestor league unique, 100% increased effect of Tattoos in Radius), and the Light of Meaning. Extra testing might be needed. Since Warrior's Tale is now only obtainble in Standard, maybe it's fine?

Steps taken to verify a working solution:

  • Import build
  • Take any node within both radius
  • Should give +7 max life instead of 5 from the +100%

Link to a build that showcases this PR:

https://pobb.in/aU7-cvnDSbOq

Before screenshot:

image

After screenshot:

image

There's a type check when calculating Increased Effect that needs the value to be "number".
out:NewMod("PassiveSkillEffect", "INC", 50, data.modSource)
end
end,
["75% increased Effect of non-Keystone Passive Skills in Radius"] = function(node, out, data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a regex instead of hardcoding percentages:

	["(%d+)%% increased Effect of non%-Keystone Passive Skills in Radius"] = function(num)
		return function(node, out, data)
			if node and node.type ~= "Keystone" and node.type ~= "ClassStart" then
				out:NewMod("PassiveSkillEffect", "INC", num, data.modSource)
			end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Might of the Meek does not work properly with Light of Meaning

2 participants