Skip to content

Conversation

@majochem
Copy link
Contributor

As per 3.27 patch notes:

Sources that specified "other" rings have been changed to clarify they work with the "opposite" ring instead.

Notes:

  • Did not change it for Thief's Torment, as it specifically mentions the plural "Rings" and presumably won't work with a third ring either
  • I used a pattern in mod parser to keep it compatible with old "other" mod wording, which is also used in the test scripts
  • This is purely a parsing change, no functionality was changed

After screenshot:

image

(Note: the "Cannot be stunned..." mod was also not supported for 'other ring' previously)
image
image

Notes:
- Did not change it for Thief's Torment, as it specifically mentions
  the plural "Rings" and presumably won't work with a third ring either
- I used a pattern in mod parser to keep it compatible with old "other"
  mod wording, which is also used in the test scripts
@majochem majochem marked this pull request as ready for review October 25, 2025 11:49
@Wires77 Wires77 added the bug: accuracy Wording differences label Oct 30, 2025
@Wires77 Wires77 merged commit 6370f76 into PathOfBuildingCommunity:dev Oct 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: accuracy Wording differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants