Skip to content

Conversation

@poyushih
Copy link
Contributor

@poyushih poyushih commented Aug 9, 2025

Fixes #8933

Ideally, we would want to display the non-ASCII chars properly. It seems to be a problem of fonts, which I'm uncertain how to fix now. This would at least allow characters with name containing non-ASCII characters to be imported to PoB.

Description of the problem being solved:

When importing data from POE with a character name containing non-ASCII characters, we will get a 400 error. This is due to the utf-8 encoding of those characters not being compatible with URL encoding.

Steps taken to verify a working solution:

  • Find an account with non-ASCII character names on poe.ninja
  • Try importing passives & items with a name containing non-ASCII characters

Link to a build that showcases this PR:

N/A

Before screenshot:

image image

After screenshot:

image image

@mmitch
Copy link

mmitch commented Aug 9, 2025

I can attest a successful test of this patch:

I ran into the same import problem with my character whose name contains a single single é (all other characters are plain ASCII).
With your patch applied to PoB 2.55.5 I can import the character again.
Thanks a a lot!

@Nightblade Nightblade added the bug Something isn't working label Aug 11, 2025
@Nightblade
Copy link
Contributor

Tested OK with:

Egniel#3548 - РикиМортьевич
marchrabbit#7904 - 絲柯克是誰
PoeXa-7410 - 入丫长仈卄
DebbieDepot#2073 - Вернадский - นางกวัก - 이물담 - 殷海光
641775132#4121 - 乔家劲

@LocalIdentity LocalIdentity changed the title Fix utf-8 encoding while fetching items & passives Fix importing characters with names that contain foreign letters Aug 11, 2025
@LocalIdentity LocalIdentity merged commit 67d9fbe into PathOfBuildingCommunity:dev Aug 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import character error Response Code: 400

4 participants