Skip to content

Fix Minion DoT DPS not including +50% DoT multiplier from Crits #8826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Fix Minion DoT DPS not including +50% DoT multiplier from Crits #8826

merged 1 commit into from
Jul 14, 2025

Conversation

@Wires77
Copy link
Member

@Wires77 Wires77 commented Jul 11, 2025 •
edited
Loading

Fixes #8824 .

Description of the problem being solved:

I'm not 100% confident this is accurate, but I can't find any evidence to the contrary without testing in game. There may be other stats in this section that should be moved to be more common (notably I'm trying to find a source for the differing totem resistance between the player and others)

Link to a build that showcases this PR:

eNqtXG1z4jgS_jz8ChdVd7VbdwGMgbxcsleEJDOpS2aykJm5-7QlbAW0ERZry8mwV_ffr1uyjXmRkYHZqh2w-l3qVuuRmct__phx541GMRPhVd1ttOoODX0RsHByVf_6fHdyVv_nL7XLJyKnX16uE8Zx5Jfah0v12eH0jXLgqzuSRBMqv2WSvN9A0pyEckpF-Eh-F9FHEVzVP4uQ1p0xCQMms28-J3H8mczoVX3kA3PdIbFPw2CwfJ4STklEfEmjB9TaT6R4FAGMvhAew_CMsHAk_FcqP0YimV_V23XnjdF3TXT_-PRl-FywiYVFm8ClD5dPnCxoNJJEOjH876re9yV7o0AKZj2wGZMgkfAExLVb9aaBB6JJJvRTgXgX7XUSxfKGzODjbp7RnNJgSdZwPa_XOe25Xsfrdk5NXIOIyceESzbnjEY5u9vomjjAgcGUhP7SJLdlNOpZSMJvnka7zdeUwiI435mcXnNw1kouUt9PQiapNfmTYLEIK1ltRTxIOIcssaId0phGb0QyS0MGYjZmoWVMBkLwQLyHy1XbaLmeifqRhGQgYouZQconGkGSykoMI-oLyOuqOipyPrAXak9ZyY-Uoao1-_lxO7Klqyx4P4OGUJ_sKEci4ZaUMrKoqUP6R5Gwd2YivKE_7MQVCc-N4u5DaSeuSOi2PbN5b0KqLc6q4Nx-esopvbNGu33utk9bp6dtY9F-mi5i5hP-SH6wWTKDGv5MXulSX69knU6mMoSyZWL1jHvLHYtoda4B1KY9uKZExEa2s7IstAgC7K3-BdLeh75dan8NI1XBC1tyr5RhCAmHu_6YU0uOpYo0bW02ZK1qQsNU38LOnQdK_elHaKSGRFK7Ip1TdcvDirRWYUXCLWHtWjJUCBIyGoLUOC9jqhim25BGk8VoyigPqlFnhg3I3Koz9C-K3FbhXlVXacUUWSuG5DuJArsdp6pNbyQuVli3Vx4uTW63MCl0o8AQ0LXG2MjxFInfKZwheDW2fjQTSWQ54ZrYyoFsd9BHjSENEt9uN7p9eaHqKHTN4YBl60bOBXZyXom1LyXxX29EMLEOmlJSiWPVvlEyn0MNwdVgKwA3PmjgWaHROelZUH-BpWyV0bhH2itYUlsryHd9ey1rLPa-4M5dwZklubWKfEIfoVjMYBNQZ2U4_y-rgXFy4MxmdaZShJYHwSfxDpZPERmJq1FDh7PsaoymRDT8c2Etf4XcSsFtGCQRpoK1jnUOKzUWKIse3ERO1kCTrtfwWufd87aJbRU8cRutjtvL_pwelWkDEel2G12vdZb37gaOLcjIBuVWZGSn_O0IyU62TZSk7bUap97pLo7VqTlvtxvnpbZtKjprNTrdVud0Z8hWrOs0zt3znpGnBJ3ZoN2BzmzK3oLO7HRi5WzidXq9MsLybmgrS3lntsFS2qyWUle0zb57fGYzaL3i-IZI4gTpGfobiRgJZVuhzzElkT99gM3ijnA-ht7hql58qr4pbPiOcUmjG3iGZQp1rEt0s23isqlAbvx0P5uLSDr0B_71RCK5yGBnRaiegJxYslCtFihQnNed0VS894M31PQsBI9zrJrM5zQMVmQ8R5Q6JOtHfDRCOY9fnBmJweqF3uBi9KaAkd8Hyo1QgAGQ0Gdnnoe-I7BDokV_lTBkYJcEXQWoHnpkjcJrSaj2w-XX4YP68GEq5Ty-aDbf398bcyKn4oX-gI624YtZcw5MYPBJ_Mo4P0GxzT78uZ701R8lqJlJutTofNzU33BbjxjYrCe5iY6qqGMk8MNnIWmMY_gw-3I5QlUxzGYkP9JZfL2AZLvDNbSWfmkokXpEpV4lRZ6ruowSirP_QhKOz39NCGc4s63i0wd9xRGKaJbjKiAKZhY7Ri3xeTHH0PcfHvRIn8tUGKrLpllPZ2qQw4JsitOH6gKjv7R6QLgfK7tZ6PMkoPdh2qXky4iTMdqGdzYIKASZT2uSckUfLsGelPgjF2PC20tZ2k_Ycp0JneFKeKSSBJByzXsJXjTRlaaSB58GC5-rS5k3nTRInz9Tq2HlyR-F0KafcfxGR7m-YpKbebHmlC-SUM9jSGZpjmQK0iWlzdszpioz8ojGcKjC-oC-X7hwyiKvBOz-K5mL-B-xc0fCyd8dWHdh4NyQyQTvVNbsjbnAnY0CR-i4FSdFGaPimNbNVesLI-nD0RxSKdKP6oV7uXwuhoTFVFPFm6IVbXGWKsyIsnU5J0qRs03TmpUbk5Z-hOxQdUBnOn5UPiqK-3CeSKXsqo6Zljk8hvJKSZha1tykRVm_hclsjDOl_8Ybwk3KGYv938bJywveG4L5MlJ3obd3d7eD5_tvtynLiKqzsxMn41h_vKp_Y_RdGX0DmcN4jBHinMxjmpd6lfaplxz4SqQpqk8svxjcLmtJYJZ0-4NGsDNNvsN2GDFqtCsf32GUVojbPO7MJmnYypoF6RP-APY1veUbIqVab7MUvNY0uoODJbywpxNu1JyO7oiExMIPq569MB9bm_Ipx21CU5XExffhBOUvSuY7hSfMMtTZwCRAD5qZdRtu4k5HS6KqThjGqOpRM_sN9YnRdz1oZs67SBGq6_ftUnKqEkmf0_MLJE2fcYQSjDN7y2lOYhb4RU5plLZvJkmPUHkyktLEidg4keY0LlCUxEqdOgwRwjEzq0b9DT7gWEklWjlcGAJapDGL0giysZCVsWpYyRi_FKQqmYIUnzWEX4-WBCGDqA3-p8MlSaLqb_9NsEADlYZ0WSMrKxjQmR8uRqGvh4tZh2MPl3gHh5tX43yno2b2r5JhX7RFiu6DrIRgUh0mAXPrMAnP0PXKJKJ7CxiudyJL3mF5D5JDiFuZs9GyypEii3tL0Pjn3uwKnt2bW9V_OO5Q8KB0A8hpSvJDJuENBEOW5IalKGXW9kKy9K6SLL0VbvW0skSd4Okdf1kN0CQ7BMFe_qmkW7STlF8xfKKEI2Yp-GECN95lOEQYgm_JnIRBJu7Lth59OQ-W0RMyBpkKDLtBjO_QGIZ0ttgiyGzXZTM7ASqYDM9ZKbg3khGe1v8UYvYfdW7FTylk46UwDXTcNwzmLVLrLdODhP_OMMZLBXGkmBF-ziEjs4AEjtMKZNNHfMVRAHpQShHkGRI4jiwunK-f73_9elvbBijUinhCLUWQLpx2q5YiZxfO9Qn8V1MODukfF07Xq8FJhTOf4ahb67T-gtBGRAmE1NHHdwcPQnjv60C02Ct19AGi5raA2FefHSmc54ihXkcJd1xn5RzvwBz-C44wtf9CEZ7Qi1aj-7-f3NPWSbvV-rmoMrtjdvQcFun7QRA7P52duN7PqO-nduvEa_28waHIXKTonjvqGjAbcbtFe_VRBA2D1a6QBDixD1Gbo3TiWxzdejoFKdZgpGjvpPB2UnR2UnR3UmTgv8Lc8nWEeKF5ua1CiVxIB85Ys6fx1-ED5oaGNWApvGE9xiEN8zbLGZbAVcbi7mK5FlApnP54Ece42NSadboVdF5TLtf52xX4Vf_ieHt46YzeyXxddWcfQQe4n8poH0HGdod6R3CodwSH9pKxzSG3yuLatjq9I0SkfSxvqqy3TxQaLXlQPLYkW-9gC9qVJRys0jtW_LtHWAzuEdLDPYIdnYor4Vglpn1oRnaOEMDqe8bRSqx3qP_tA1O4mgHBwtF41SFrUPcWh0jYntjdgyX0jjWt7rFqTPWleXgcOwfPZfc4i6qK8_1Zwqk8QiX0jlBQvAOTsnMgv3uc-O-9U1ZetJ3KHPt0UQdGtXtorT7StHSOVVyO1lfvfYSqwDdk4aTSFG4vTe3jzMHRdopjHPg6-_lUNfiH7_FHaja6Bxty-BbXq1oMDi0emwo16qNff0GkkwR0pFDO7xRfuo81FKqgSvVWjAhf2CQFLfWXFLZU_PkTRzLJaeFtqyJeVHz1hWjwfvXFl8Hw_jnzr0jM1FW-Ha2fxFLMgDZe0q6hj3OF5tX-ph6PSUwdP0MtY41aatpat4XkQOaQIKABPhaxExTegVGvmPt0KnhAo9QCiphz-iJ39vbPaau1g2HlNwsZm7eLK_-FRPbmTv66Ubvj7tIYLX92n7F1d_AUf4aS8-x0DZ7sYR_q2oNNYcpLjrOOmX6W_ysF-FI4jWgwUm8K4btmI8pfllLcroWPlQOTz94T3sbkk27LVX0icI2th_TsvLeDLX-JII9Gy-14FqtrXZVns1JsYzHyhbqUgQmLC6bt0JD-Hk1wrkDxYobu4Mz2vYyh556fnZt5YjZh_MuLusoFI9V9tK2Rqz-eq5w01hGcwu5gCOBlM6_p-lJMffuldtlc__dZ_g9dIUVY

@Wires77 Wires77 added the bug: calculation Numerical differences label Jul 11, 2025
@LocalIdentity LocalIdentity changed the title Moving the Dot Multiplier on crit to be common for all actors Fix Minion DoT DPS not including +50% DoT multiplier from Crits Jul 14, 2025
@LocalIdentity LocalIdentity merged commit 4fe61a9 into PathOfBuildingCommunity:dev Jul 14, 2025
2 checks passed
Wires77 added a commit to Wires77/PathOfBuilding that referenced this pull request Jul 15, 2025
@Wires77
Revert "Moving the Dot Multiplier on crit to be common for all actors (…
282a0d4 
…PathOfBuildingCommunity#8826)"

This reverts commit 4fe61a9.
Wires77 added a commit that referenced this pull request Jul 18, 2025
@Wires77
Fix missing Minion DoT multiplier from critical hits (#8841)
f918743 
* Revert "Moving the Dot Multiplier on crit to be common for all actors (#8826)"

This reverts commit 4fe61a9.

* Adjust minion DoT multiplier from critical hits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

bug: calculation Numerical differences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minion DoT DPS does not include +50% DoT multiplier from crits

2 participants

@Wires77 @LocalIdentity