Skip to content

Remove Channelling time config box for Focused Channelling - Existing users should update their config #8823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Remove Channelling time config box for Focused Channelling - Existing users should update their config #8823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Data/Skills/sup_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2326,10 +2326,10 @@ skills["SupportFocusedChannelling"] = {
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_focus_channel_cost_+%_final_per_second_channelling_up_to_100%"] = {
mod("Cost", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingSeconds", limit = 100, limitTotal = true }),
mod("Cost", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingTime", limit = 100, limitTotal = true }),
},
["support_focus_channel_damage_+%_final_per_second_channelling_up_to_60%"] = {
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingSeconds", limit = 60, limitTotal = true }),
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingTime", limit = 60, limitTotal = true }),
},
},
qualityStats = {
Expand Down
4 changes: 2 additions & 2 deletions src/Export/Skills/sup_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ local skills, mod, flag, skill = ...
#skill SupportFocusedChannelling
statMap = {
["support_focus_channel_cost_+%_final_per_second_channelling_up_to_100%"] = {
mod("Cost", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingSeconds", limit = 100, limitTotal = true }),
mod("Cost", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingTime", limit = 100, limitTotal = true }),
},
["support_focus_channel_damage_+%_final_per_second_channelling_up_to_60%"] = {
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingSeconds", limit = 60, limitTotal = true }),
mod("Damage", "MORE", nil, 0, 0, { type = "Multiplier", var = "ChannellingTime", limit = 60, limitTotal = true }),
},
},
#mods
Expand Down
4 changes: 0 additions & 4 deletions src/Modules/ConfigOptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,6 @@ return {
{ var = "FlickerStrikeBypassCD", type = "check", label = "Bypass CD?", ifSkill = "Flicker Strike", includeTransfigured = true, defaultState = true, apply = function(val, modList, enemyModList)
modList:NewMod("CooldownRecovery", "OVERRIDE", 0, "Config", { type = "SkillName", skillName = "Flicker Strike", includeTransfigured = true })
end },
{ label = "Focused Channelling Support:", ifSkill = "Focused Channelling" },
{ var = "channellingSeconds", type = "count", label = "Seconds spent Channelling:", ifSkill = "Focused Channelling", tooltip = "Sets the amount of time you've spent channelling in seconds.", apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:ChannellingSeconds", "BASE", val, "Config")
end },
{ label = "Fresh Meat:", ifSkill = "Fresh Meat" },
{ var = "freshMeatBuffs", type = "check", label = "Is Fresh Meat active?", ifSkill = "Fresh Meat", apply = function(val, modList, enemyModList)
modList:NewMod("Condition:FreshMeatActive", "FLAG", true, "Config")
Expand Down