Fix support gems not adding their flags if they themselves require a flag added by a support gem lower in the supportList #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
force-pushed
the
supportgemorder
branch
from
ee820a5 to
7e4c440
Compare
Co-authored-by: QuickStick <31533893+QuickStick123@users.noreply.github.com>
LocalIdentity
approved these changes
Sep 14, 2022
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4851
Description of the problem being solved:
In some cases support gems that required skillTypes flags added by support gems lower in the socket group would not work.
Steps taken to verify a working solution:
See issue for screenshots