Skip to content

Commit ac25fb2

Browse files
LocalIdentityPaliakLocalIdentity
authored
Fix Volatility applying to Minion Spell skills (#8912)
* FIX(mirage): fix cap GC cooldown by mirage+attack delay The Howlcrack unique item sets the cooldown of warcies to 0 causing the GC dps to explode into infinity due to division by zero. This was caused by the assumption that the mirages instantly spawn and attack. This commit makes it so that the cooldown is at least the amount of time it takes to spawm them all and attack or channel for 1s. * FIX: cleanup handling of limitedSkills table * FIX: cleanup target skill selection for SacredWisps and MirageArcher * FIX: mark the cache generated by mirage calcs as CALCULATOR The env used by mirage skills is often modified causing the resulting env to differ. This has not caused issues to there not beign any caching use after calcMirages but this could come up in the future. Marking the env as CALCULATOR still allows for the env to be cached in case it's really needed but it will prevent it being used in most cases. * FIX: remove vestigial CACHE table This was once used as the main table holding the cached output of skills. It has been entirely replaced by the remaining tables. * MISC: typo * FIX: typo * Fix Volatility applying to Minion Spell skills Volatility was not being restricted to minion spells after we recently changed how we were applying support gems to minions --------- Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent f68de28 commit ac25fb2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Data/Skills/sup_str.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4380,10 +4380,10 @@ skills["SupportVolatility"] = {
43804380
statDescriptionScope = "gem_stat_descriptions",
43814381
statMap = {
43824382
["minimum_attack_damage_+%_final_from_volatility_support"] = {
4383-
mod("MinDamage", "MORE", nil),
4383+
mod("MinDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }),
43844384
},
43854385
["maximum_attack_damage_+%_final_from_volatility_support"] = {
4386-
mod("MaxDamage", "MORE", nil),
4386+
mod("MaxDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }),
43874387
},
43884388
},
43894389
qualityStats = {

src/Export/Skills/sup_str.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,10 +603,10 @@ local skills, mod, flag, skill = ...
603603
#skill SupportVolatility
604604
statMap = {
605605
["minimum_attack_damage_+%_final_from_volatility_support"] = {
606-
mod("MinDamage", "MORE", nil),
606+
mod("MinDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }),
607607
},
608608
["maximum_attack_damage_+%_final_from_volatility_support"] = {
609-
mod("MaxDamage", "MORE", nil),
609+
mod("MaxDamage", "MORE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Attack }),
610610
},
611611
},
612612
#mods

0 commit comments

Comments
 (0)