FIX: incorrect warnings when using eb and drop support for per second costs. (#5247)

* FEAT: Stop disabling aura effects when unreserved mana is negative. Add
a warning for when LifeCost or ManaCost is higher than avilable pool.

* FEAT: Make mana cost warnings show for all enabled active skill gems not
just mainSkill.

* FIX: generalize match condition for cost coloring.

* FIX: Add support for mana cost warning for triggered skills.

* FIX: fix copy paste typo.

* FEAT: implement warnings for energy shield and rage cost. Minor tweaks.

* Apply suggestions from code review

Co-authored-by: QuickStick <31533893+QuickStick123@users.noreply.github.com>

* FIX: Add better handling for eldrich battery. Minor tweaks.

* FIX: fix other costs missing from top level cache table.

* FIX: add compatibility with #5199

* FIX: mana warnings showing up when using EB

* FIX: remove per second cost warning

Per second cost warnings are hard to make accurate to due the amount of
recovery sources avilable both in poe and in pob.

Co-authored-by: QuickStick <31533893+QuickStick123@users.noreply.github.com>

Author: Paliak

src/Modules/Build.lua

@@ -1339,7 +1339,7 @@ function buildMode:AddDisplayStatList(statList, actor)
 						local output = actor.output
 						local poolVal = output[statData.pool]
 						local colorOverride = nil
-						if statData.stat:match("Cost$") and statVal and poolVal then
+						if statData.stat:match("Cost$") and not statData.stat:match("PerSecondCost$") and statVal and poolVal then
 							if statData.stat == "ManaCost" and output.EnergyShieldProtectsMana then
 								if statVal > output.ManaUnreserved + output.EnergyShield then
 									colorOverride = colorCodes.NEGATIVE
@@ -1376,13 +1376,7 @@ function buildMode:AddDisplayStatList(statList, actor)
 			InsertIfNew(self.controls.warnings.lines, line)
 		end
 	end
-	for pool, warningFlag in pairs({["Life"] = "LifePerSecondCostPerSecondWarning", ["Mana"] = "ManaPerSecondCostPerSecondWarning", ["Rage"] = "RagePerSecondCostPerSecondWarning", ["EnergyShield"] = "ESPerSecondCostPerSecondWarning"}) do
-		if actor.output[warningFlag] then
-			local line = "You do not have enough ".. pool .." to use a Selected Skill for a second"
-			InsertIfNew(self.controls.warnings.lines, line)
-		end
-	end
-	for pool, warningFlag in pairs({["Unreserved life"] = "LifePercentCostPercentPerSecondWarning", ["Unreserved life"] = "LifePercentPerSecondCostPercentPerSecondWarning", ["Unreserved Mana"] = "ManaPercentPerSecondCostPercentPerSecondWarning", ["Unreserved Mana"] = "ManaPercentCostPercentPerSecondWarning", ["EnergyShield"] = "ESPercentPerSecondCostPercentPerSecondWarning"}) do
+	for pool, warningFlag in pairs({["Unreserved life"] = "LifePercentCostPercentCostWarning", ["Unreserved Mana"] = "ManaPercentCostPercentCostWarning"}) do
 		if actor.output[warningFlag] then
 			local line = "You do not have enough ".. pool .."% to use a Selected Skill"
 			InsertIfNew(self.controls.warnings.lines, line)

src/Modules/Calcs.lua

@@ -416,34 +416,18 @@ function calcs.buildOutput(build, mode)
 			for pool, costResource in pairs({["LifeUnreserved"] = "LifeCost", ["ManaUnreserved"] = "ManaCost", ["Rage"] = "RageCost", ["EnergyShield"] = "ESCost"}) do
 				local cachedCost = GlobalCache.cachedData["CACHE"][uuid].Env.player.output[costResource]
 				if cachedCost then
-					if EB and costResource == "Mana" then --Handling for mana cost warnings with EB allocated
+					if EB and costResource == "ManaCost" then --Handling for mana cost warnings with EB allocated
 						output.EnergyShieldProtectsMana = true
 						output[costResource.."Warning"] = output[costResource.."Warning"] or (((output[pool] or 0) + (output["EnergyShield"] or 0)) < cachedCost)
 					else
 						output[costResource.."Warning"] = output[costResource.."Warning"] or ((output[pool] or 0) < cachedCost) -- defaulting to 0 to avoid crashing
 					end
 				end
 			end
-			for pool, costResource in pairs({["LifeUnreserved"] = "LifePerSecondCost", ["ManaUnreserved"] = "ManaPerSecondCost", ["Rage"] = "RagePerSecondCost", ["EnergyShield"] = "ESPerSecondCost"}) do
+			for pool, costResource in pairs({["LifeUnreservedPercent"] = "LifePercentCost", ["ManaUnreservedPercent"] = "ManaPercentCost"}) do
 				local cachedCost = GlobalCache.cachedData["CACHE"][uuid].Env.player.output[costResource]
 				if cachedCost then
-					if EB and costResource == "Mana" then
-						output.EnergyShieldProtectsMana = true
-						output[costResource.."PerSecondWarning"] = output[costResource.."PerSecondWarning"] or (((output[pool] or 0) + (output["EnergyShield"] or 0)) < cachedCost)
-					else
-						output[costResource.."PerSecondWarning"] = output[costResource.."PerSecondWarning"] or ((output[pool] or 0) < cachedCost)
-						ConPrintf(costResource.."PerSecondWarning".." "..(output[costResource.."PerSecondWarning"] and "true" or "false"))
-					end
-				end
-			end
-			for pool, costResource in pairs({["LifeUnreservedPercent"] = "LifePercentCost", ["LifeUnreservedPercent"] = "LifePercentPerSecondCost", ["ManaUnreservedPercent"] = "ManaPercentPerSecondCost", ["ManaUnreservedPercent"] = "ManaPercentCost", ["ESPercentPerSecondCost"] = "ESPercentPerSecondCost"}) do
-				local cachedCost = GlobalCache.cachedData["CACHE"][uuid].Env.player.output[costResource]
-				if cachedCost then
-					if costResource == "ESPercentPerSecondCost" then --Assuming 100% of Es is always available
-						output["ESPercentPerSecondCostPercentPerSecondWarning"] = output["ESPercentPerSecondCostPercentPerSecondWarning"] or ((output["EnergyShield"] or 0) < cachedCost)
-					else
-						output[costResource.."PercentPerSecondWarning"] = output[costResource.."PercentPerSecondWarning"] or ((output[pool] or 0) < cachedCost)
-					end
+					output[costResource.."PercentCostWarning"] = output[costResource.."PercentCostWarning"] or ((output[pool] or 0) < cachedCost)
 				end
 			end
 		end