Skip to content

Commit a51cdca

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Ancestral and Seismic Cry incorrectly granting damage with Echoes (#9464)
Exerts for Seismic and Ancestral Cry were being applied to any skill instead of just slam skills so when the code in Calc Perform went to count the number of Warcries that were exerting a skill, those 2 warcries would count for all melee skills Now filter the skill types that those 2 can exert Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 93956f7 commit a51cdca

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Data/Skills/act_str.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ skills["AncestralCry"] = {
294294
castTime = 0.8,
295295
statMap = {
296296
["skill_empowers_next_x_melee_attacks"] = {
297-
mod("AncestralExertedAttacks", "BASE", nil),
297+
mod("AncestralExertedAttacks", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.MeleeSingleTarget }),
298298
},
299299
["ancestral_cry_elemental_resist_%_per_5_power_up_to_cap"] = {
300300
mod("ElementalResist", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Warcry", div = 5, limit = 30 }),
@@ -9054,7 +9054,7 @@ skills["SeismicCry"] = {
90549054
castTime = 0.8,
90559055
statMap = {
90569056
["skill_empowers_next_x_melee_attacks"] = {
9057-
mod("SeismicExertedAttacks", "BASE", nil),
9057+
mod("SeismicExertedAttacks", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Slam }),
90589058
},
90599059
["seismic_cry_base_slam_skill_area_+%_final"] = {
90609060
mod("SeismicAoEMoreMultiplier", "BASE", nil),

src/Export/Skills/act_str.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ local skills, mod, flag, skill = ...
5151
#flags warcry area duration
5252
statMap = {
5353
["skill_empowers_next_x_melee_attacks"] = {
54-
mod("AncestralExertedAttacks", "BASE", nil),
54+
mod("AncestralExertedAttacks", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.MeleeSingleTarget }),
5555
},
5656
["ancestral_cry_elemental_resist_%_per_5_power_up_to_cap"] = {
5757
mod("ElementalResist", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Warcry", div = 5, limit = 30 }),
@@ -1723,7 +1723,7 @@ local skills, mod, flag, skill = ...
17231723
#flags warcry area duration
17241724
statMap = {
17251725
["skill_empowers_next_x_melee_attacks"] = {
1726-
mod("SeismicExertedAttacks", "BASE", nil),
1726+
mod("SeismicExertedAttacks", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Slam }),
17271727
},
17281728
["seismic_cry_base_slam_skill_area_+%_final"] = {
17291729
mod("SeismicAoEMoreMultiplier", "BASE", nil),

0 commit comments

Comments
 (0)