Skip to content

Commit 8eee6f4

Browse files
committed
Fix "Full Poison DPS" value capping to one stack (#8460)
* Fix Full Poison DPS only showing one poison stack * Cap from multiple sources
1 parent dd352af commit 8eee6f4

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/Modules/Calcs.lua

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
181181
combinedDPS = 0,
182182
TotalDotDPS = 0,
183183
skills = { },
184-
poisonDPS = 0,
184+
TotalPoisonDPS = 0,
185185
causticGroundDPS = 0,
186186
impaleDPS = 0,
187187
igniteDPS = 0,
@@ -222,7 +222,7 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
222222
igniteSource = activeSkill.activeEffect.grantedEffect.name
223223
end
224224
if usedEnv.minion.output.PoisonDPS and usedEnv.minion.output.PoisonDPS > 0 then
225-
fullDPS.poisonDPS = fullDPS.poisonDPS + usedEnv.minion.output.PoisonDPS * activeSkillCount
225+
fullDPS.TotalPoisonDPS = fullDPS.TotalPoisonDPS + usedEnv.minion.output.TotalPoisonDPS * activeSkillCount
226226
end
227227
if usedEnv.minion.output.ImpaleDPS and usedEnv.minion.output.ImpaleDPS > 0 then
228228
fullDPS.impaleDPS = fullDPS.impaleDPS + usedEnv.minion.output.ImpaleDPS * activeSkillCount
@@ -258,7 +258,7 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
258258
igniteSource = activeSkill.activeEffect.grantedEffect.name .. " (Mirage)"
259259
end
260260
if activeSkill.mirage.output.PoisonDPS and activeSkill.mirage.output.PoisonDPS > 0 then
261-
fullDPS.poisonDPS = fullDPS.poisonDPS + activeSkill.mirage.output.PoisonDPS * mirageCount
261+
fullDPS.TotalPoisonDPS = fullDPS.TotalPoisonDPS + activeSkill.mirage.output.TotalPoisonDPS * mirageCount
262262
end
263263
if activeSkill.mirage.output.ImpaleDPS and activeSkill.mirage.output.ImpaleDPS > 0 then
264264
fullDPS.impaleDPS = fullDPS.impaleDPS + activeSkill.mirage.output.ImpaleDPS * mirageCount
@@ -303,7 +303,7 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
303303
burningGroundSource = activeSkill.activeEffect.grantedEffect.name
304304
end
305305
if usedEnv.player.output.PoisonDPS and usedEnv.player.output.PoisonDPS > 0 then
306-
fullDPS.poisonDPS = fullDPS.poisonDPS + usedEnv.player.output.PoisonDPS * activeSkillCount
306+
fullDPS.TotalPoisonDPS = fullDPS.TotalPoisonDPS + usedEnv.player.output.TotalPoisonDPS * activeSkillCount
307307
end
308308
if usedEnv.player.output.CausticGroundDPS and usedEnv.player.output.CausticGroundDPS > fullDPS.causticGroundDPS then
309309
fullDPS.causticGroundDPS = usedEnv.player.output.CausticGroundDPS
@@ -353,10 +353,10 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
353353
t_insert(fullDPS.skills, { name = "Best Burning Ground DPS", dps = fullDPS.burningGroundDPS, count = 1, source = burningGroundSource })
354354
fullDPS.TotalDotDPS = fullDPS.TotalDotDPS + fullDPS.burningGroundDPS
355355
end
356-
if fullDPS.poisonDPS > 0 then
357-
fullDPS.poisonDPS = m_min(fullDPS.poisonDPS, data.misc.DotDpsCap)
358-
t_insert(fullDPS.skills, { name = "Full Poison DPS", dps = fullDPS.poisonDPS, count = 1 })
359-
fullDPS.TotalDotDPS = fullDPS.TotalDotDPS + fullDPS.poisonDPS
356+
if fullDPS.TotalPoisonDPS > 0 then
357+
fullDPS.TotalPoisonDPS = m_min(fullDPS.TotalPoisonDPS, data.misc.DotDpsCap)
358+
t_insert(fullDPS.skills, { name = "Full Poison DPS", dps = fullDPS.TotalPoisonDPS, count = 1 })
359+
fullDPS.TotalDotDPS = fullDPS.TotalDotDPS + fullDPS.TotalPoisonDPS
360360
end
361361
if fullDPS.causticGroundDPS > 0 then
362362
t_insert(fullDPS.skills, { name = "Best Caustic Ground DPS", dps = fullDPS.causticGroundDPS, count = 1, source = causticGroundSource })

0 commit comments

Comments
 (0)