Skip to content

Commit 5872756

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Ailments breakdown showing crit damage while you have Res Technique (#6164)
There's no need to show the crit breakdown for Ignite/Bleed or other ailments if you cannot crit Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 1373dd0 commit 5872756

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Modules/CalcOffence.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3467,7 +3467,7 @@ function calcs.offence(env, actor, activeSkill)
34673467
if isAttack then
34683468
t_insert(breakdownDPS, pass.label..":")
34693469
end
3470-
if sourceHitDmg == sourceCritDmg then
3470+
if sourceHitDmg == sourceCritDmg or output.CritChance == 0 then
34713471
t_insert(breakdownDPS, "Total damage:")
34723472
t_insert(breakdownDPS, s_format("%.1f ^8(source damage)",sourceHitDmg))
34733473
if sourceMult > 1 then
@@ -3576,7 +3576,7 @@ function calcs.offence(env, actor, activeSkill)
35763576
end
35773577
end
35783578
if globalBreakdown then
3579-
if sourceHitDmg == sourceCritDmg then
3579+
if sourceHitDmg == sourceCritDmg or output.CritChance == 0 then
35803580
globalBreakdown.BleedDPS = {
35813581
s_format(colorCodes.CUSTOM.."NOTE: Calculation uses new Weighted Avg Ailment formula"),
35823582
s_format(""),
@@ -4041,7 +4041,7 @@ function calcs.offence(env, actor, activeSkill)
40414041
output.IgniteTotalMax = totalMax
40424042
end
40434043
if globalBreakdown then
4044-
if sourceHitDmg == sourceCritDmg then
4044+
if sourceHitDmg == sourceCritDmg or output.CritChance == 0 then
40454045
globalBreakdown.IgniteDPS = {
40464046
s_format(colorCodes.CUSTOM.."NOTE: Calculation uses new Weighted Avg Ailment formula"),
40474047
s_format(""),

0 commit comments

Comments
 (0)