Load Gem tooltips on hover instead of when sorting by DPS #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first and safest addition for reducing the load time of the gem DPS sort There's no need to generate all of the tooltips when trying to sort the list by DPS. Instead of pre-generating 200 gem tooltips, it's better to generate them when hovering over the gem as each one only takes ~2-10ms This PR also removes support gems that add effects to buff gems from being included in the sort list e.g. Clarity II was checked for DPS despite never being able to support a skill like Arc directly
LocalIdentity
added
pob1
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Oct 26, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Oct 30, 2025
…#9049) * Apply changes from PathOfBuildingCommunity/PathOfBuilding-PoE2#1504 * Fix merge issue --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first and safest addition for reducing the load time of the gem DPS sort
There's no need to generate all of the tooltips when trying to sort the list by DPS.
Instead of pre-generating 200 gem tooltips, it's better to generate them when hovering over the gem as each one only takes ~2-10ms
This PR also removes support gems that add effects to buff gems from being included in the sort list
e.g. Clarity II was checked for DPS despite never being able to support a skill like Arc directly
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/hx16gt0c
Before screenshot:
After screenshot:
~220ms improvement on Fresh load
~200ms improvement after JIT cache is warm