Fix various issues with subscript errors #1345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
added
bug
|
this commit gives me crashes when starting and loggin in
|
LocalIdentity
pushed a commit
that referenced
this pull request
Sep 11, 2025
This reverts commit 601a278.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1322 and other issues with authentication has made me realize we don't handle subscript errors properly in some cases.
Notably, PoEAPI has a callback that accepts 3 parameters, which is fine when everything works. However, if there is an error in the subscript, launch:OnSubError() gets called and that callback receives only 2 parameters, the second one just being an error message that gets swallowed up. This PR fixes that so at least the error gets printed to the console.
To test this we can add a purposeful syntax error to either the LaunchServer script or the launch:DownloadPage one, as they both had issues of this nature.