Skip to content

Commit a11f82b

Browse files
laanwjPastaPastaPasta
authored andcommitted
Merge bitcoin#20635: fix misleading comment about call to non-existing function
cc3044c fix misleading comment about call to non-existing function (pox) Pull request description: The comment seems to be describing the subsequent call to `SyncTransaction` but refers to it as `SyncNotifications`, which is not any function currently in the codebase. It's best to just remove the "what" aspect of the comment and focus on the "why", which also reduces the risk of similar documentation errors in the future, in case the function ever gets renamed, for example. ACKs for top commit: laanwj: ACK cc3044c Tree-SHA512: 882ff17836ef585a603dc504f3dd21f56f682e49b28a0998f23fd16025826fbb083b7978db3ee70d0e0ff2c86fd6c3fd99a2361e5d45c765fdc5822c5f14c0a7
1 parent ec44ccb commit a11f82b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/wallet/wallet.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -1240,9 +1240,8 @@ void CWallet::transactionRemovedFromMempool(const CTransactionRef& tx, MemPoolRe
12401240
// Handle transactions that were removed from the mempool because they
12411241
// conflict with transactions in a newly connected block.
12421242
if (reason == MemPoolRemovalReason::CONFLICT) {
1243-
// Call SyncNotifications, so external -walletnotify notifications will
1244-
// be triggered for these transactions. Set Status::UNCONFIRMED instead
1245-
// of Status::CONFLICTED for a few reasons:
1243+
// Trigger external -walletnotify notifications for these transactions.
1244+
// Set Status::UNCONFIRMED instead of Status::CONFLICTED for a few reasons:
12461245
//
12471246
// 1. The transactionRemovedFromMempool callback does not currently
12481247
// provide the conflicting block's hash and height, and for backwards

0 commit comments

Comments
 (0)