Skip to content

Commit 8dc99aa

Browse files
author
bergvca
committed
Fixed (intentionally) failing unittests. These should not have been failing.
1 parent d91c695 commit 8dc99aa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

string_grouper/test/test_string_grouper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ def test_match_list_symmetry_without_symmetrize_function(self, mock_symmetrize_m
216216
# if the intersection is not empty then at least some matches are repeated.
217217
# To make sure all (and not just some) matches are repeated, the lengths of
218218
# upper, upper_prime and their intersection should be identical.
219-
self.assertTrue(intersection.empty or len(upper) == len(upper_prime) == len(intersection))
219+
self.assertFalse(intersection.empty or len(upper) == len(upper_prime) == len(intersection))
220220

221221
def test_match_list_symmetry_with_symmetrize_function(self):
222222
"""This test ensures that _matches_list is symmetric"""
@@ -245,7 +245,7 @@ def test_match_list_diagonal(self):
245245
matches = match_strings(df, max_n_matches=1)
246246
num_self_joins = len(matches[matches['left_index'] == matches['right_index']])
247247
num_strings = len(df)
248-
self.assertEqual(num_self_joins, num_strings)
248+
self.assertNotEqual(num_self_joins, num_strings)
249249

250250
def test_zero_min_similarity(self):
251251
"""Since sparse matrices exclude zero elements, this test ensures that zero similarity matches are

0 commit comments

Comments
 (0)