Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete NServiceBus.Logging in favor of Microsoft.Extensions.Logging #7038

Open
ramonsmits opened this issue May 23, 2024 · 1 comment
Open

Comments

@ramonsmits
Copy link
Member

ramonsmits commented May 23, 2024

Describe the suggested improvement

Is your improvement related to a problem? Please describe.

NServiceBus.Logging exists in all versions of Core. Its a logging abstraction by NServiceBus that is from the time the .NET ecosystem didn't have a defacto abstraction. Now that Microsoft.Extensions.Logging has matured there is no reason for NServiceBus users to use its abstraction.

This also fixes issues with NServiceBus.Logging.LogManager being a service locator pattern and any loggers created could conflict when multiple endpoints are hosted in a single process

Suggestion

Mark all public types in NServiceBus.Logging with [Obsolete]with guidance to transition toMicrosoft.Extensions.Logging`

Additional Context

No response

Related

Currently abstraction blocks certain refactorings like:

@ramonsmits ramonsmits changed the title Obsolete NServiceBus.Logging Obsolete NServiceBus.Logging in favor of Microsoft.Extensions.Logging Jul 1, 2024
@ramonsmits
Copy link
Member Author

@jbogard asked if we have an overview of all categories like:

When we eventually will move away from our limited abstraction it would be nice if such an overview could be added (or even auto generated) in our docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant