Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name SendFailedMessagesTo doesn't accurately reflect what the API does #6715

Open
kbaley opened this issue Apr 4, 2023 · 0 comments
Open

Comments

@kbaley
Copy link
Contributor

kbaley commented Apr 4, 2023

Describe the suggested improvement

Calling SendFailedMessagesTo will forward failed messages to the specified queue which is intuitive. However, behind the scenes, the API also changes the name of the queue itself (from the default "error" to the name specified in the API). The name of the API doesn't make this clear and it could lead to confusion.

Other issues with the name of the API:

  • SendFailedMessagesTo makes it sound like it's doing something right now; maybe SetErrorQueueName?
  • If this API isn't called, it's not clear that messages will still be sent to a default error queue
  • The name of the API is hard to find; it doesn't mention the words "error queue" which is what our documentation refers to

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant