Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component refactoring cleanup #5534

Open
timbussmann opened this issue Nov 25, 2019 · 0 comments
Open

Component refactoring cleanup #5534

timbussmann opened this issue Nov 25, 2019 · 0 comments

Comments

@timbussmann
Copy link
Contributor

timbussmann commented Nov 25, 2019

With the refactoring efforts around the hosting, receive and send components, a lot of workarounds had to be added for backwards compatibility. With the next major version, those workarounds can/should be removed in order to simplify the code quite a bit.

  • Remove the internal settings access by the component's Settings classes
  • Change transport initialization by removing the marked obsolete methods in the SendComponent to the component's regular Initialization process.
  • Consider removal of featureComponent.RegisterFeatureEnabledStatusInSettings(hostingConfiguration); functionality in EndpointCreator.Initialize that is needed to allow transports to know if the TimeoutManager is enabled or not (needed to for backwards compatibility around native timeouts)
    • Consider removing feature state completely from settings
  • Remove obsolete marked methods in HostComponent
@timbussmann timbussmann added this to the 8.0.0 milestone Nov 25, 2019
@HEskandari HEskandari modified the milestones: 8.0.0, Future Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants