Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous connections stay active after reconnect, causing resource exhaustion #1439

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Aug 22, 2024

dependabot bot and others added 2 commits August 22, 2024 08:26
* Bump Particular/setup-rabbitmq-action from 1.6.0 to 1.7.0

Bumps [Particular/setup-rabbitmq-action](https://github.com/particular/setup-rabbitmq-action) from 1.6.0 to 1.7.0.
- [Commits](Particular/setup-rabbitmq-action@v1.6.0...v1.7.0)

---
updated-dependencies:
- dependency-name: Particular/setup-rabbitmq-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix flaky tests

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
* Abort loop earlier if possible

* Reduce nesting

* Swap the connection when ready

* Explicit break to reduce nesting

* Nullable enable

* Move connection related stuff into the connection folder

* Adjust the channel provider design slightly to achieve better testability without too much test induced damage

* Test various races that can occur during shutdown and reconnection

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
@danielmarbach danielmarbach changed the title Reliability r91 Improve reliability of channel provider in case of reconnects Aug 22, 2024
@danielmarbach danielmarbach marked this pull request as ready for review August 22, 2024 06:31
@danielmarbach danielmarbach merged commit 2a53c69 into release-9.1 Aug 22, 2024
3 checks passed
@danielmarbach danielmarbach deleted the reliability-r91 branch August 22, 2024 10:56
@danielmarbach danielmarbach added this to the 9.1.1 milestone Aug 22, 2024
@danielmarbach danielmarbach changed the title Improve reliability of channel provider in case of reconnects Prevent connections from leaking in case of reconnects Aug 22, 2024
@danielmarbach danielmarbach changed the title Prevent connections from leaking in case of reconnects Previous connections stay active after reconnect, causing resource exhaustion Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants