Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception info when users share types between sagas #703

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Improve exception info when users share types between sagas #703

merged 1 commit into from
Oct 24, 2022

Conversation

ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Dec 30, 2021 •
edited
Loading

@ramonsmits ramonsmits self-assigned this Dec 30, 2021
@ramonsmits
Copy link
Member Author

@singhvivek2503 I made this improvement in our code base. Could you review this and let me know if the suggestion exception message type would have helped you resolve this much faster?

@singhvivek2503
Copy link

@ramonsmits Yes, LGTM. Thanks.

@stale
Copy link

stale bot commented Jan 29, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Jan 29, 2022
@stale stale bot added stale and removed stale labels Mar 6, 2022
@stale stale bot added the stale label Apr 21, 2022
singhvivek2503
singhvivek2503 approved these changes Apr 21, 2022
View reviewed changes
Copy link

@singhvivek2503 singhvivek2503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale stale bot removed the stale label Apr 21, 2022
@stale stale bot added the stale label May 25, 2022
@ramonsmits ramonsmits removed the stale label Jun 1, 2022
@Particular Particular deleted a comment from stale bot Jun 1, 2022
@Particular Particular deleted a comment from stale bot Jun 1, 2022
@Particular Particular deleted a comment from stale bot Jun 1, 2022
@stale stale bot added the stale label Jul 7, 2022
@Particular Particular deleted a comment from stale bot Jul 8, 2022
@ramonsmits ramonsmits removed the stale label Jul 8, 2022
@stale stale bot added the stale label Aug 10, 2022
@ramonsmits ramonsmits force-pushed the index-already-exist-guidance-exception branch from 6fc0f41 to 1fdb963 Compare August 11, 2022 13:10
@stale stale bot removed the stale label Aug 11, 2022
@stale stale bot added the stale label Sep 17, 2022
@github-actions github-actions bot closed this Sep 25, 2022
@Particular Particular deleted a comment from stale bot Sep 30, 2022
@Particular Particular deleted a comment from stale bot Sep 30, 2022
@ramonsmits ramonsmits reopened this Sep 30, 2022
@ramonsmits ramonsmits force-pushed the index-already-exist-guidance-exception branch from 1fdb963 to 95d3f7a Compare September 30, 2022 12:15
@github-actions github-actions bot removed the stale label Oct 1, 2022
@ramonsmits ramonsmits merged commit b47b1f4 into master Oct 24, 2022
@ramonsmits ramonsmits deleted the index-already-exist-guidance-exception branch October 24, 2022 08:07
@ramonsmits ramonsmits added this to the 9.1.0 / next milestone Oct 24, 2022
@cquirosj cquirosj added the Bug label Dec 23, 2022
soujay pushed a commit that referenced this pull request Dec 26, 2022
@ramonsmits @soujay
Improve exception info when users share types between sagas (#703)
0333a74
@soujay soujay mentioned this pull request Dec 26, 2022
Merged
soujay added a commit that referenced this pull request Dec 26, 2022
@soujay @ramonsmits
Improve exception info when users share types between sagas (#703) (#930
57295f2 
)

Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
@soujay soujay removed this from the 9.0.1 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasohlund andreasohlund andreasohlund approved these changes

@singhvivek2503 singhvivek2503 singhvivek2503 approved these changes

Assignees

@ramonsmits ramonsmits

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramonsmits @singhvivek2503 @andreasohlund @cquirosj @soujay