-
Notifications
You must be signed in to change notification settings - Fork 33
Add content API url filter #3386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA new filter hook, Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Endpoint_Posts
participant External_Filter
participant Content_API
Caller->>Endpoint_Posts: get_posts(params)
Endpoint_Posts->>Endpoint_Posts: Prepare post URLs
Endpoint_Posts->>External_Filter: Apply 'wp_parsely_stats_posts_urls' filter to URLs
External_Filter-->>Endpoint_Posts: Return modified URLs
Endpoint_Posts->>Content_API: Make request with (possibly filtered) URLs
Content_API-->>Endpoint_Posts: Return results
Endpoint_Posts-->>Caller: Return results
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
This is a minor filter addition that gives us some useful capabilities when testing. We currently have some test sites that mirror live Parse.ly data from our other sites. In these circumstances, it can be useful to convert some not real local URLs to remote URLs that match our Parse.ly setup, like this:
This filter adds a foothold so we can easily make those testing changes without editing plugin code.
Motivation and context
This fixes a testing and deployment task we currently need to do when pushing changes to our test sites.
How has this been tested?
Integration tests will cover that this does not cause any issues.
Summary by CodeRabbit