Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project updates for python 3.12 compatibility #194

Merged
merged 5 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
36 changes: 18 additions & 18 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,30 @@
version: 2.1

orbs:
python: circleci/python@0.3.2
python: circleci/python@2.1.1

jobs:
python_test:
parameters:
python_ver:
type: string
default: "3.6"
default: "3.11"
docker:
- image: circleci/python:<< parameters.python_ver >>
- image: cimg/python:<< parameters.python_ver >>
steps:
- checkout
- python/load-cache:
dependency-file: requirements_dev.txt
key: depsv3-{{ .Branch }}.{{ arch }}-PY<< parameters.python_ver >>
# - python/load-cache: # This command is unavailable in the orb
# dependency-file: requirements_dev.txt
# key: depsv3-{{ .Branch }}.{{ arch }}-PY<< parameters.python_ver >>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ParallelSSH/ssh-python@97cfd5c

iirc this is now automated and doesn't have to happen explicitly

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I was thinking, so can remove it in follow-up commits.

- run:
name: Deps
command: |
sudo apt-get update
sudo apt-get install cmake openssh-server
pip install -r requirements_dev.txt
- python/save-cache:
dependency-file: requirements_dev.txt
key: depsv3-{{ .Branch }}.{{ arch }}-PY<< parameters.python_ver >>
# - python/save-cache: # This command is unavailable in the orb
# dependency-file: requirements_dev.txt
# key: depsv3-{{ .Branch }}.{{ arch }}-PY<< parameters.python_ver >>
- run:
command: |
python setup.py build_ext --inplace
Expand Down Expand Up @@ -93,9 +93,9 @@ jobs:
image: ubuntu-2004:202201-02
steps: &manylinux-steps
- checkout
- python/load-cache:
key: manylinuxdepsv6-{{ .Branch }}.{{ arch }}
dependency-file: requirements_dev.txt
# - python/load-cache: # This command is unavailable in the orb
# key: manylinuxdepsv6-{{ .Branch }}.{{ arch }}
# dependency-file: requirements_dev.txt
- run:
name: Git LFS
command: |
Expand All @@ -112,9 +112,9 @@ jobs:
which twine
which python
which python3
- python/save-cache:
key: manylinuxdepsv6-{{ .Branch }}.{{ arch }}
dependency-file: requirements_dev.txt
# - python/save-cache: # This command is unavailable in the orb
# key: manylinuxdepsv6-{{ .Branch }}.{{ arch }}
# dependency-file: requirements_dev.txt
- run:
name: Build Wheels
command: |
Expand All @@ -139,17 +139,17 @@ jobs:
steps: *manylinux-steps

workflows:
version: 2.1
version: 2
main:
jobs:
- python_test:
matrix:
parameters:
python_ver:
- "3.6"
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"
filters:
tags:
ignore: /.*/
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ wheelhouse
.idea/
ssh2/libssh2.so*
doc/_build
venv
ven*
3 changes: 2 additions & 1 deletion ci/appveyor/fix_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
import sys

def get_describe_tag():
return subprocess.check_output(['git', 'describe', '--tags']).strip().decode('utf-8')
ver, change, commit = subprocess.check_output(['git', 'describe', '--tags']).strip().decode('utf-8').split('-')
return f'{ver}+{change}.{commit}' # PEP440 compatible

def make_version_file(basedir):
rev = os.environ.get('APPVEYOR_REPO_COMMIT',
Expand Down
Loading