Skip to content

Commit 33b42c9

Browse files
committed
chore(api): resolve some of the warnings and test compile errors
1 parent c072052 commit 33b42c9

File tree

11 files changed

+22
-9
lines changed

11 files changed

+22
-9
lines changed

api/src/main/java/net/kyori/adventure/text/event/HoverEventImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ public ShowItem count(final @Range(from = 0, to = Integer.MAX_VALUE) int count)
8989
}
9090

9191
@Override
92+
@Deprecated
9293
public ShowItem nbt(final @Nullable BinaryTagHolder nbt) {
9394
if (Objects.equals(nbt, this.nbt)) return this;
9495
return new ShowItemImpl(this.item, this.count, nbt, Collections.emptyMap());

api/src/main/java/net/kyori/adventure/text/renderer/AbstractComponentRenderer.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@
4242
* @since 4.0.0
4343
*/
4444
public abstract class AbstractComponentRenderer<C> implements ComponentRenderer<C> {
45+
46+
public AbstractComponentRenderer() {
47+
}
48+
4549
@Override
4650
public Component render(Component component, final C context) {
4751
if (component instanceof VirtualComponent vc) {

api/src/main/java/net/kyori/adventure/text/renderer/TranslatableComponentRenderer.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ public abstract class TranslatableComponentRenderer<C> extends AbstractComponent
6868
MERGES = Collections.unmodifiableSet(merges);
6969
}
7070

71+
public TranslatableComponentRenderer() {
72+
}
73+
7174
/**
7275
* Creates a {@link TranslatableComponentRenderer} using the {@link Translator} to translate.
7376
*

api/src/main/java/net/kyori/adventure/util/Listenable.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@
3636
public abstract class Listenable<L> {
3737
private final List<L> listeners = new CopyOnWriteArrayList<>();
3838

39+
public Listenable() {
40+
}
41+
3942
/**
4043
* Process an action for each listener.
4144
*

api/src/main/java/net/kyori/adventure/util/UTF8ResourceBundleControl.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343
public final class UTF8ResourceBundleControl extends ResourceBundle.Control {
4444
private static final UTF8ResourceBundleControl INSTANCE = new UTF8ResourceBundleControl();
4545

46+
private UTF8ResourceBundleControl() {
47+
}
48+
4649
/**
4750
* Gets the shared instance.
4851
*

api/src/test/java/net/kyori/adventure/text/AbstractComponentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
import static org.junit.jupiter.api.Assertions.assertSame;
4848
import static org.junit.jupiter.api.Assertions.assertTrue;
4949

50-
abstract class AbstractComponentTest<C extends BuildableComponent<C, B> & ScopedComponent<C>, B extends ComponentBuilder<C, B>> {
50+
abstract class AbstractComponentTest<C extends ScopedComponent<C>, B extends ComponentBuilder<C, B>> {
5151
abstract B builder();
5252

5353
final C buildOne() {

api/src/test/java/net/kyori/adventure/text/AbstractNBTComponentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import static org.junit.jupiter.api.Assertions.assertFalse;
3030
import static org.junit.jupiter.api.Assertions.assertTrue;
3131

32-
abstract class AbstractNBTComponentTest<C extends NBTComponent<C, B> & ScopedComponent<C>, B extends NBTComponentBuilder<C, B>> extends AbstractComponentTest<C, B> {
32+
abstract class AbstractNBTComponentTest<C extends NBTComponent<C> & ScopedComponent<C>, B extends NBTComponentBuilder<C, B>> extends AbstractComponentTest<C, B> {
3333
@Test
3434
void testBuildWithInterpret() {
3535
final C c0 = this.buildOne();

api/src/test/java/net/kyori/adventure/text/event/ClickEventTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ void testEquality() throws MalformedURLException {
7575

7676
@Test
7777
void assertReadable() {
78-
final Set<ClickEvent.Action> unreadable = new HashSet();
78+
final Set<ClickEvent.Action<?>> unreadable = new HashSet<>();
7979
unreadable.add(ClickEvent.Action.OPEN_FILE);
8080
unreadable.add(ClickEvent.Action.SHOW_DIALOG);
81-
for (final ClickEvent.Action action : ClickEvent.Action.values()) {
81+
for (final ClickEvent.Action<?> action : ClickEvent.Action.NAMES.values()) {
8282
assertEquals(action.readable(), !unreadable.contains(action));
8383
}
8484
}

api/src/test/java/net/kyori/adventure/text/event/HoverEventTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
class HoverEventTest {
4040
@Test
4141
void testAsHoverEvent() {
42-
final HoverEventImpl<Component> event = HoverEvent.showText(Component.text("kittens"));
42+
final HoverEvent<Component> event = HoverEvent.showText(Component.text("kittens"));
4343
assertSame(event, event.asHoverEvent());
4444
assertSame(event, event.asHoverEvent(UnaryOperator.identity()));
4545
assertEquals(HoverEvent.showText(Component.text("cats")), event.asHoverEvent(old -> Component.text("cats")));

api/src/test/java/net/kyori/adventure/translation/TranslationStoreTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class TranslationStoreTest {
5050
static void testRegister() {
5151
REGISTRY.register("what", Locale.CANADA, new MessageFormat("A what?", Locale.CANADA));
5252

53-
final ResourceBundle bundle = ResourceBundle.getBundle("adventure-test", Locale.US, UTF8ResourceBundleControl.get());
53+
final ResourceBundle bundle = ResourceBundle.getBundle("adventure-test", Locale.US, UTF8ResourceBundleControl.utf8ResourceBundleControl());
5454
REGISTRY.registerAll(Locale.US, bundle, true);
5555
}
5656

@@ -206,7 +206,6 @@ void testEquality() {
206206
.testEquals();
207207
}
208208

209-
@Test
210209
@AfterAll
211210
static void testUnregister() {
212211
REGISTRY.unregister("test");

0 commit comments

Comments
 (0)