Fix player autosave#459
Open
Dueris wants to merge 1 commit into
Open
Conversation
Contributor
|
This PR fixes a critical bug in the game that can cause a rollback (very important) after a crash (I've already experienced this). I strongly advise merging it as soon as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folia forgets to set the
lastSavelongfield on join of a player, making it so that Folia doesn't ever run autosave on players unless saved manually, of which after a manual save, autosave starts because inPlayerlist#save(Lnet/minecraft/server/level/ServerPlayer;), thelongfield,lastSaveis set. By setting this on join toSystem.nanoTime()and checking for theLAST_SAVE_ABSENTvalue during autosave, this fixes players not being autosavedOriginal:
https://github.com/CraftCanvasMC/Canvas/blob/00b4aed9f9a2c17300a9603827075b761962787d/canvas-server/minecraft-patches/base/0008-Fixup-Region-Threading.patch#L3954
CraftCanvasMC/Canvas#210