refactor: make xtramcp backend configurable #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the XtraMCP backend configuration by externalizing the hardcoded URI into a configurable environment variable, following the pattern used for other configuration values in the codebase.
- Moved the XtraMCP server URI from hardcoded string to configuration
- Added
XtraMCPURIfield to theCfgstruct with environment variable support - Updated the client initialization to use the configurable URI
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/libs/cfg/cfg.go | Added XtraMCPURI field to config struct and xtraMCPURI() helper function with environment variable support and default fallback |
| internal/services/toolkit/client/client.go | Updated XtraMCP loader initialization to use configurable URI from cfg instead of hardcoded string |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place configurable URI in Cfg.