code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/SpringDocConfiguration.java

@@ -30,8 +30,6 @@
 import java.util.Map;
 import java.util.Optional;
 
-import static org.springdoc.core.Constants.SPRINGDOC_SORT_CONVERTER_ENABLED;
-import org.springframework.data.domain.Sort;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import io.swagger.v3.core.converter.ModelConverter;
 import io.swagger.v3.oas.annotations.Hidden;
@@ -94,6 +92,7 @@
 import org.springframework.core.LocalVariableTableParameterNameDiscoverer;
 import org.springframework.core.convert.support.GenericConversionService;
 import org.springframework.data.domain.Pageable;
+import org.springframework.data.domain.Sort;
 import org.springframework.data.rest.core.config.RepositoryRestConfiguration;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
@@ -110,6 +109,7 @@
 import static org.springdoc.core.Constants.SPRINGDOC_SCHEMA_RESOLVE_PROPERTIES;
 import static org.springdoc.core.Constants.SPRINGDOC_SHOW_ACTUATOR;
 import static org.springdoc.core.Constants.SPRINGDOC_SHOW_SPRING_CLOUD_FUNCTIONS;
+import static org.springdoc.core.Constants.SPRINGDOC_SORT_CONVERTER_ENABLED;
 import static org.springdoc.core.SpringDocUtils.getConfig;
 
 /**

springdoc-openapi-common/src/main/java/org/springdoc/core/SwaggerUiConfigParameters.java

@@ -24,7 +24,6 @@
 
 import java.net.URL;
 import java.util.Comparator;
-import java.util.HashSet;
 import java.util.LinkedHashSet;
 import java.util.Map;
 import java.util.Set;

springdoc-openapi-common/src/main/java/org/springdoc/core/SwaggerUiConfigProperties.java

@@ -22,17 +22,18 @@
 
 package org.springdoc.core;
 
+import java.util.LinkedHashSet;
+import java.util.Set;
+import java.util.stream.Collectors;
+
 import org.apache.commons.lang3.StringUtils;
+
 import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.boot.context.properties.ConfigurationProperties;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Lazy;
 
-import java.util.LinkedHashSet;
-import java.util.Set;
-import java.util.stream.Collectors;
-
 import static org.springdoc.core.Constants.SPRINGDOC_SWAGGER_UI_ENABLED;
 
 

springdoc-openapi-common/src/main/java/org/springdoc/core/converters/SortOpenAPIConverter.java

@@ -1,5 +1,3 @@
-package org.springdoc.core.converters;
-
 /*
  *
  *  *
@@ -21,6 +19,9 @@
  *  *
  *
  */
+
+package org.springdoc.core.converters;
+
 import java.util.Iterator;
 
 import com.fasterxml.jackson.databind.JavaType;

springdoc-openapi-common/src/main/java/org/springdoc/core/converters/models/Sort.java

@@ -1,5 +1,3 @@
-package org.springdoc.core.converters.models;
-
 /*
  *
  *  *
@@ -22,6 +20,8 @@
  *
  */
 
+package org.springdoc.core.converters.models;
+
 import java.util.List;
 import java.util.Objects;
 

springdoc-openapi-common/src/test/java/org/springdoc/api/AbstractOpenApiResourceTest.java

@@ -29,7 +29,6 @@
 import java.util.Map;
 import java.util.Optional;
 
-import io.swagger.v3.core.util.Json;
 import io.swagger.v3.oas.annotations.enums.ParameterIn;
 import io.swagger.v3.oas.models.OpenAPI;
 import io.swagger.v3.oas.models.Operation;

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app31/HelloController.java

@@ -18,7 +18,10 @@
 
 package test.org.springdoc.api.app31;
 
+import java.util.List;
+
 import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.domain.Sort;
 import org.springframework.data.domain.Sort.Direction;
@@ -27,8 +30,6 @@
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RestController;
 
-import java.util.List;
-
 @RestController
 public class HelloController {
 

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app31/SpringDocApp31Test.java

@@ -23,9 +23,10 @@
 
 package test.org.springdoc.api.app31;
 
-import org.springframework.boot.autoconfigure.SpringBootApplication;
 import test.org.springdoc.api.AbstractSpringDocTest;
 
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
 public class SpringDocApp31Test extends AbstractSpringDocTest {
 
 	@SpringBootApplication

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app32/HelloController.java

@@ -18,14 +18,15 @@
 
 package test.org.springdoc.api.app32;
 
+import java.util.List;
+
 import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.data.domain.Sort;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RestController;
 
-import java.util.List;
-
 @RestController
 public class HelloController {
 

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app32/SpringDocApp32Test.java

@@ -23,21 +23,22 @@
 
 package test.org.springdoc.api.app32;
 
+import java.util.Optional;
+
 import org.springdoc.core.customizers.DataRestDelegatingMethodParameterCustomizer;
 import org.springdoc.core.customizers.DelegatingMethodParameterCustomizer;
 import org.springdoc.core.providers.RepositoryRestConfigurationProvider;
 import org.springdoc.core.providers.SpringDataWebPropertiesProvider;
 import org.springdoc.data.rest.SpringDocDataRestConfiguration;
+import test.org.springdoc.api.AbstractSpringDocTest;
+
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
 import org.springframework.boot.autoconfigure.data.rest.RepositoryRestMvcAutoConfiguration;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Lazy;
 import org.springframework.test.context.TestPropertySource;
-import test.org.springdoc.api.AbstractSpringDocTest;
-
-import java.util.Optional;
 
 @TestPropertySource(properties = "spring.data.web.sort.sort-parameter=sorts")
 @EnableAutoConfiguration(exclude = {

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app33/ExampleSort.java

@@ -1,10 +1,11 @@
 package test.org.springdoc.api.app33;
 
+import java.util.List;
+
 import com.fasterxml.jackson.annotation.JsonProperty;
 import io.swagger.v3.oas.annotations.Parameter;
-import org.springframework.data.domain.Sort;
 
-import java.util.List;
+import org.springframework.data.domain.Sort;
 
 public class ExampleSort extends Sort {
 

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app33/ExampleSortReplacement.java

@@ -1,10 +1,10 @@
 package test.org.springdoc.api.app33;
 
+import java.util.List;
+
 import io.swagger.v3.oas.annotations.Parameter;
 import org.springdoc.core.converters.models.Sort;
 
-import java.util.List;
-
 public class ExampleSortReplacement extends Sort {
 
 	@Parameter(description = "Anything")

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app33/HelloController.java

@@ -1,6 +1,7 @@
 package test.org.springdoc.api.app33;
 
 import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app33/SpringDocApp33Test.java

@@ -19,9 +19,10 @@
 package test.org.springdoc.api.app33;
 
 import org.springdoc.core.SpringDocUtils;
-import org.springframework.boot.autoconfigure.SpringBootApplication;
 import test.org.springdoc.api.AbstractSpringDocTest;
 
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
 public class SpringDocApp33Test extends AbstractSpringDocTest {
 
 	@SpringBootApplication

springdoc-openapi-javadoc/src/main/java/org/springdoc/openapi/javadoc/JavadocPropertyCustomizer.java

@@ -28,7 +28,6 @@
 import java.util.Map;
 import java.util.Optional;
 
-import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.annotation.JsonUnwrapped;
 import com.fasterxml.jackson.databind.JavaType;
 import io.swagger.v3.core.converter.AnnotatedType;

springdoc-openapi-javadoc/src/test/java/test/org/springdoc/api/app165/HelloController.java

@@ -18,11 +18,11 @@
 
 package test.org.springdoc.api.app165;
 
+import io.swagger.v3.oas.annotations.parameters.RequestBody;
+
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RestController;
 
-import io.swagger.v3.oas.annotations.parameters.RequestBody;
-
 /**
  * The type Hello controller.
  */

springdoc-openapi-javadoc/src/test/java/test/org/springdoc/api/app165/SpringDocApp165Test.java

@@ -18,10 +18,10 @@
 
 package test.org.springdoc.api.app165;
 
-import org.springframework.boot.autoconfigure.SpringBootApplication;
-
 import test.org.springdoc.api.AbstractSpringDocTest;
 
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
 /**
  * The type Spring doc app 165 test.
  */

springdoc-openapi-javadoc/src/test/java/test/org/springdoc/api/app166/HelloController.java

@@ -24,6 +24,7 @@
 
 
 import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;

springdoc-openapi-javadoc/src/test/java/test/org/springdoc/api/app166/SpringDocApp166Test.java

@@ -18,9 +18,10 @@
 
 package test.org.springdoc.api.app166;
 
-import org.springframework.boot.autoconfigure.SpringBootApplication;
 import test.org.springdoc.api.AbstractSpringDocTest;
 
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
 /**
  * The type Spring doc app 165 test.
  */

springdoc-openapi-native/src/test/java/test/org/springdoc/api/app1/TestApplicationTests.java

@@ -23,6 +23,7 @@
 package test.org.springdoc.api.app1;
 
 import org.junit.jupiter.api.Test;
+
 import org.springframework.boot.SpringBootConfiguration;
 import org.springframework.boot.test.context.SpringBootTest;
 

springdoc-openapi-webflux-core/src/test/java/test/org/springdoc/api/app186/SpringDocApp186Test.java

@@ -20,21 +20,21 @@
 
 package test.org.springdoc.api.app186;
 
-import static org.springdoc.core.Constants.ALL_PATTERN;
-
 import org.junit.jupiter.api.Test;
 import org.springdoc.core.Constants;
 import org.springdoc.core.GroupedOpenApi;
 import org.springdoc.core.customizers.OpenApiCustomiser;
 import org.springdoc.core.customizers.OperationCustomizer;
+import test.org.springdoc.api.AbstractCommonTest;
+
 import org.springframework.boot.actuate.autoconfigure.endpoint.web.WebEndpointProperties;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.test.context.TestPropertySource;
 
-import test.org.springdoc.api.AbstractCommonTest;
+import static org.springdoc.core.Constants.ALL_PATTERN;
 
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
 @TestPropertySource(properties={ "springdoc.show-actuator=true",

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/v30/app186/SpringDocApp186Test.java

@@ -22,25 +22,24 @@
 
 package test.org.springdoc.api.v30.app186;
 
-import static org.hamcrest.Matchers.is;
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
-
 import org.junit.jupiter.api.Test;
 import org.springdoc.core.Constants;
 import org.springdoc.core.GroupedOpenApi;
 import org.springdoc.core.customizers.OpenApiCustomiser;
 import org.springdoc.core.customizers.OperationCustomizer;
+import test.org.springdoc.api.v30.AbstractSpringDocV30Test;
+
 import org.springframework.boot.actuate.autoconfigure.endpoint.web.WebEndpointProperties;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.context.annotation.Bean;
 import org.springframework.test.context.TestPropertySource;
 
-import test.org.springdoc.api.v30.AbstractSpringDocV30Test;
-
+import static org.hamcrest.Matchers.is;
 import static org.springdoc.core.Constants.ALL_PATTERN;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
 @TestPropertySource(properties = { "springdoc.show-actuator=true",
 		"springdoc.group-configs[0].group=group-actuator-as-properties",

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/v30/app190/HelloController.java

@@ -24,6 +24,7 @@
 
 
 import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/v30/app190/SpringDocApp190Test.java

@@ -22,9 +22,10 @@
 
 package test.org.springdoc.api.v30.app190;
 
-import org.springframework.boot.autoconfigure.SpringBootApplication;
 import test.org.springdoc.api.v30.AbstractSpringDocV30Test;
 
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
 public class SpringDocApp190Test extends AbstractSpringDocV30Test {
 
     @SpringBootApplication

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/v30/app191/HelloController.java

@@ -22,7 +22,10 @@
 
 package test.org.springdoc.api.v30.app191;
 
+import java.util.List;
+
 import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.domain.Sort;
 import org.springframework.data.domain.Sort.Direction;
@@ -31,8 +34,6 @@
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RestController;
 
-import java.util.List;
-
 @RestController
 public class HelloController {