Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-toastify from 9.1.3 to 10.0.4 #1950

Closed
palisadoes opened this issue Apr 29, 2024 · 6 comments
Closed

Upgrade react-toastify from 9.1.3 to 10.0.4 #1950

palisadoes opened this issue Apr 29, 2024 · 6 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file no-issue-activity No issue activity security Security fix

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade react-toastify from 9.1.3 to 10.0.4.
  2. Existing configurations must not be modified
  3. No other functionality must be affected
  4. All tests must be valid and pass

Background Failing PRs

@palisadoes palisadoes added the bug Something isn't working label Apr 29, 2024
@palisadoes palisadoes added security Security fix dependencies Pull requests that update a dependency file labels Apr 29, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 10, 2024
@adithyanotfound
Copy link

I want to work on this issue. Please assign this issue to me

@varshith257
Copy link
Member

Here you go @adithyanotfound !

@adithyanotfound
Copy link

The reason for react-toastify version 10.0.4 not working is because it require react version 18 or above.
Screenshot 2024-08-03 at 5 44 34 PM
The current version of react is 17.0.2. Should I proceed to upgrade react?
It will involve changing the render method to createRoot in multiple files.

@varshith257
Copy link
Member

Yes, proceed. We need to be up to date with packages.

Reference:
https://react.dev/blog/2022/03/08/react-18-upgrade-guide

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file no-issue-activity No issue activity security Security fix
Projects
None yet
Development

No branches or pull requests

3 participants