Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Page Images, Social Icons and URLs Missing When the Sample Database is Loaded #1859

Closed
palisadoes opened this issue Apr 1, 2024 · 6 comments
Assignees
Labels
bug Something isn't working ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  • Login Page Images, Social Icons and URLs Missing When the Sample Database is Loaded

To Reproduce
Steps to reproduce the behavior:

  1. Load sample database in the API
  2. Access the Talawa-Admin login page
  3. Social media icons and images are missing
  4. Login as a SuperAdmin
  5. Reset the community settings
  6. Logout
  7. The correct login page images are shown

Expected behavior

  1. Display the correct images, icons and URLs when the community collection values are blank
    1. The issues linked below indicate where you can look to research the fix.
    2. The default values should be located in the src/constants.ts file
  2. This could be done in the default data load, but that would mean editing values in two repos. Doing it all here increases the chances of consistency.

Actual behavior

  • See above

Screenshots

  1. Login page showing the bug

    image

  2. Community Profile reset page

    image

  3. Login page after resetting

    image

Additional details

  1. Add the ability to change pre-login imagery #1334
  2. Feature: Ability to change pre-login imagery #1649
  3. Add support to change pre-login imagery talawa-api#1611
  4. Added support for pre-login imagery talawa-api#1935

Potential internship candidates

@palisadoes palisadoes added bug Something isn't working ui/ux issue related and being worked with the figma file of the Admin UI labels Apr 1, 2024
@akhilender-bongirwar
Copy link
Contributor

I just went through this issue and realized that we are unnecessarily populating data for communities, as we already have supported code in our frontend to handle null data. The simple solution is to remove the default data population while importing sample data, and everything will work fine.

2024-04-03.13-19-51.mp4

@palisadoes sir, please check the video. If this is what we are expecting, then I would like to open an issue and work on it for the talawa-api.

@palisadoes
Copy link
Contributor Author

Please prove that this works using the setup.ts script when the:

  1. sample data is loaded
  2. default organization data is loaded

@akhilender-bongirwar
Copy link
Contributor

I used npm run setup command.

  • When the sample data is loaded
2024-04-04.13-52-58.mp4
  • When the default organization data is loaded
2024-04-04.13-54-43.mp4

@palisadoes
Copy link
Contributor Author

Thanks. Please create a PR

@akhilender-bongirwar
Copy link
Contributor

Thanks. Please create a PR

Made an issue in the API. Will create a PR once assigned.

@akhilender-bongirwar
Copy link
Contributor

@dhanagopu, as per the conversation. This issue can be closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Development

No branches or pull requests

3 participants