Give option to disable converting from transcription text to ids. #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinghai-sun
approved these changes
Nov 3, 2017
| speech_segment, self._keep_transcription_text) | ||
| specgram = self._normalizer.apply(specgram) | ||
| return specgram, text_ids | ||
| return specgram, transcript_part |
There was a problem hiding this comment.
Please modify the function doc in Line 106.
deep_speech_2/infer.py
Outdated
| target_transcripts = [ | ||
| ''.join([data_generator.vocab_list[token] for token in transcript]) | ||
| for _, transcript in infer_data | ||
| transcript for _, transcript in infer_data |
There was a problem hiding this comment.
Line 106 - 108 could be put into one line ?
deep_speech_2/test.py
Outdated
| target_transcripts = [ | ||
| ''.join([data_generator.vocab_list[token] for token in transcript]) | ||
| for _, transcript in infer_data | ||
| transcript for _, transcript in infer_data |
There was a problem hiding this comment.
Line 107 - 109 could be put into single line?
deep_speech_2/tools/tune.py
Outdated
| ''.join([data_generator.vocab_list[token] for token in transcript]) | ||
| for _, transcript in infer_data | ||
| transcript for _, transcript in infer_data | ||
| ] |
There was a problem hiding this comment.
Line 167 - 169 --> single line?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393