【Hackathon 5 No.16】为 Paddle 新增 EmbeddingBag API #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add api design for embedding_bag
Charles-hit
reviewed
Oct 12, 2023
| 仿照之前PR中的设计: | ||
|
|
||
| ```Python | ||
| def embedding_bag(input, params, weight, mode, name=None) -> Tensor: |
There was a problem hiding this comment.
这儿是否缺少了一个sparse参数,params参数是否可以改成padding_idx命名 跟embedding保持一致
There was a problem hiding this comment.
是的，缺少的sparse参数后续会补上；
params参数为了和embedding保持一致预期改为weight;
原本的weight为了和pytorch一致预期更名为per_sample_weight
| """ | ||
| ``` | ||
|
|
||
| ## API 实现方案 |
There was a problem hiding this comment.
之前的pr中没有考虑sparse的情况，这儿实现需要考虑sparse相关实现
| # 五、设计思路与实现方案 | ||
|
|
||
| ## 命名与参数设计 | ||
| 仿照之前PR中的设计: |
| ## API 实现方案 | ||
| 总体实现参考[增加C++算子教程](https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/api_contributing_guides/new_cpp_op_cn.html) | ||
|
|
||
| 1. 分别对CPU和GPU环境下增加kernel实现,确保CI均编译通过 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Description
【Hackathon 5 No.16】为 Paddle 新增 EmbeddingBag API