Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.23】为 Paddle 新增 ConcatDataset API RFC #646

Merged
merged 3 commits into from
Nov 2, 2023
Merged

【Hackathon 5th No.23】为 Paddle 新增 ConcatDataset API RFC #646

merged 3 commits into from
Nov 2, 2023

Conversation

Patrick-Star125
Copy link
Contributor

@Patrick-Star125 Patrick-Star125 commented Sep 25, 2023 •
edited
Loading

新增 ConcatDataset API 设计文档，和API PR同步修改

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@Patrick-Star125 Patrick-Star125 mentioned this pull request Sep 25, 2023
Merged
2 tasks
@Ligoml Ligoml mentioned this pull request Sep 25, 2023
Open
lxd-cumt
lxd-cumt reviewed Oct 17, 2023
View reviewed changes
rfcs/APIs/20230925_api_design_for_ConcatDataset.md Outdated
测试考虑的case如下：

- 正确性验证：
- 不同 shape；
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的不同shape是？是正确性验证的一项吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，调整了一下格式

lxd-cumt
lxd-cumt approved these changes Oct 30, 2023
View reviewed changes
Copy link

@lxd-cumt lxd-cumt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 623dcdf into PaddlePaddle:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxd-cumt lxd-cumt lxd-cumt approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees

@luotao1 luotao1

@lxd-cumt lxd-cumt

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Patrick-Star125 @luotao1 @lxd-cumt