2nd PR on Interactive Graph 0.0.3 #348
Conversation
daming-lu
commented
Mar 29, 2018
daming-lu
commented
- switched from cytoscape to dagre+d3 as the latter can build more complex nodes
- add more info to node
frontend/package.json
Outdated
| "htmlcs": "^0.4.1", | ||
| "lesslint": "^1.0.2", | ||
| "lodash": "^4.17.4", | ||
| "lodash": "^3.10.0 ", |
There was a problem hiding this comment.
Is there is reason for downgrading the version?
There was a problem hiding this comment.
Just tested and the higher version also works. I will work on how to get rid of dagre-d3 and use a combination of dagre and d3. The library dagre-d3 is not well-maintained. Think about the 'require' bug 😢
frontend/src/App.vue
Outdated
| @@ -55,13 +55,13 @@ export default { | |||
| overflow scroll | |||
| border solid 1px $-left-border-color | |||
| background $-left-border-color | |||
| min-height 300px | |||
| min-height 1300px | |||
There was a problem hiding this comment.
Is there a reason to increase the min-height so much?
There was a problem hiding this comment.
changed it back. As I showed you, I will add scrolling functionality for the long graph.
frontend/src/graph/ui/Chart.vue
Outdated
| import cytoscape from 'cytoscape'; | ||
| import dagre from 'cytoscape-dagre'; | ||
|
|
||
| // for cytoscape |
There was a problem hiding this comment.
Since we will remove the cytoscape from the package.json, we can also remove this part.
| @@ -50,121 +58,73 @@ | |||
| } | |||
| }, | |||
| mounted() { | |||
| var that = this; | |||
There was a problem hiding this comment.
Thank you for getting rid of this.
… into add_more_info_to_node
|
❤️ |
