-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLM] Update sequence parallel linear import #8706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8706 +/- ##
===========================================
- Coverage 55.70% 55.70% -0.01%
===========================================
Files 623 623
Lines 97399 97424 +25
===========================================
+ Hits 54255 54268 +13
- Misses 43144 43156 +12 ☔ View full report in Codecov by Sentry. |
gongel
previously approved these changes
Jul 3, 2024
gongel
pushed a commit
that referenced
this pull request
Jul 9, 2024
gongel
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Models
Description
ColumnSequenceParallelLinear
andRowSequenceParallelLinear
fromlinear_utils
, whereColumnSequenceParallelLinear
andRowSequenceParallelLinear
are defined for different deivces includinggpu
,npu
andxpu
.nn.Linear
is replace bylinear_utils.Linear
. When device isgpu
ornpu
,nn.Linear
is equal tolinear_utils.Linear
. When device is 'xpu',linear_utils.Linear
is designed forxpu
based onnn.Linear
, which can achieve better performance.