Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scaling #8256

Merged
merged 4 commits into from
Apr 12, 2024
Merged

add scaling #8256

merged 4 commits into from
Apr 12, 2024

Conversation

lugimzzz
Copy link
Contributor

PR types

New features

PR changes

Others

Description

scaling for slora

Copy link

paddle-bot bot commented Apr 11, 2024

Thanks for your contribution!

JunnYu
JunnYu previously approved these changes Apr 11, 2024
Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -136,6 +147,7 @@ def from_pretrained(cls, pretrained_model_name_or_path, **kwargs):
raise ValueError(f"Can't find lora_config.json at '{pretrained_model_name_or_path}'")

loaded_attributes = cls.from_json_file(config_file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉应该在from_json_file的时候就pop了

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 0d05544 into PaddlePaddle:develop Apr 12, 2024
8 checks passed
@lugimzzz lugimzzz deleted the scale branch April 12, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants