Integrate FT into generation api #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoshengCS
changed the title
guoshengCS
changed the title
smallv0221
approved these changes
Oct 27, 2021
| # TODO(guosheng): Currently, beam_search_v2 in FasterTransformer uses | ||
| # t2t beam search which has some difference with beam search in generation | ||
| # api on finish queue addition and early-stop criterion, and it seems | ||
| # lead to poor performance on bart cnn-sum model, thus we disable it temporarily. |
Contributor
There was a problem hiding this comment.
不是之后会把加速版的的beam_search改成hf的么，应该不用禁掉beam_search吧
| return False | ||
| # Some checks on kwargs. For example, FasterBART needs `mem_seq_lens` as | ||
| # one input while BART not, thus check whether `mem_seq_lens` in kwargs. | ||
| if model_kwargs.get('mem_seq_lens', None) is None: |
Contributor
There was a problem hiding this comment.
mem_seq_lens的获取可以移到FasterBart中，保证generate接受的参数统一
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Add the first draft for integrating FT into generation api.