-
Notifications
You must be signed in to change notification settings - Fork 5.7k
"polish code" #9318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"polish code" #9318
Conversation
python/paddle/fluid/executor.py
Outdated
# TODO(dzhwinter) : only use the first place | ||
self.executor = core.Executor(act_places[0]) | ||
def __init__(self, place): | ||
self.executor = core.Executor(place) | ||
self.places = places |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
places
is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
self.program_caches = dict() | ||
|
||
def aslodtensor(self, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm removing parsing lod is OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to use the nested numpy array to represent a LodTensor, but now we use two structure to do the same thing-- an array of data, a list of lod.
polish executor python code