Skip to content

Add more times close test #9215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2018
Merged

Add more times close test #9215

merged 1 commit into from
Mar 19, 2018

Conversation

chengduoZH
Copy link
Contributor

@JiayiFeng This unit test calls Close operation many times to close the same channel, and it works.

abhinavarora
abhinavarora approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhinavarora abhinavarora merged commit 597ba3f into PaddlePaddle:develop Mar 19, 2018
blacksheep-Aristotle pushed a commit to blacksheep-Aristotle/Paddle that referenced this pull request Nov 22, 2024
@lvdongyi
[Tokenizer] Support reading Tiktoken tokenizer.model. (PaddlePaddle#9215
ec25cb8 
)

* add support of tiktoken tokenizer, refactor some code

* add case of built-in tokenizers to handle CI error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

1 more reviewer

@abhinavarora abhinavarora abhinavarora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chengduoZH @abhinavarora